wip

Author: lukesandberg

turbopack/crates/turbo-tasks-macros/src/value_trait_macro.rs

@@ -284,6 +284,7 @@ pub fn value_trait(args: TokenStream, input: TokenStream) -> TokenStream {
             });
 
         impl turbo_tasks::VcValueTrait for Box<dyn #trait_ident> {
+            // type Read = dyn #trait_ident;
             fn get_trait_type_id() -> turbo_tasks::TraitTypeId {
                 *#trait_type_id_ident
             }

turbopack/crates/turbo-tasks/src/trait_ref.rs

@@ -4,7 +4,7 @@ use anyhow::Result;
 use serde::{Deserialize, Serialize};
 
 use crate::{
-    Vc, VcValueTrait,
+    Vc, VcRead, VcValueTrait, VcValueType,
     registry::get_value_type,
     task::shared_reference::TypedSharedReference,
     vc::{ReadVcFuture, VcValueTraitCast, cast::VcCast},
@@ -72,6 +72,17 @@ impl<'de, T> Deserialize<'de> for TraitRef<T> {
     }
 }
 
+// impl<T> std::ops::Deref for TraitRef<T>
+// where
+//     T: VcValueTrait,
+// {
+//     type Target = <T as VcValueTrait>::Read;
+
+//     fn deref(&self) -> &Self::Target {
+//         &*self.shared_reference.1.0 as &Self::Target
+//     }
+// }
+
 // Otherwise, TraitRef<Box<dyn Trait>> would not be Sync.
 // SAFETY: TraitRef doesn't actually contain a T.
 unsafe impl<T> Sync for TraitRef<T> where T: ?Sized {}

turbopack/crates/turbo-tasks/src/vc/traits.rs

@@ -1,3 +1,5 @@
+use std::any::Any;
+
 use crate::{
     NonLocalValue, ShrinkToFit, TraitTypeId, ValueTypeId, VcRead, vc::cell_mode::VcCellMode,
 };
@@ -26,6 +28,8 @@ pub unsafe trait VcValueType: ShrinkToFit + Sized + Send + Sync + 'static {
 /// A trait implemented on all values trait object references that can be put
 /// into a Value Cell ([`Vc<Box<dyn Trait>>`][crate::Vc]).
 pub trait VcValueTrait: NonLocalValue + Send + Sync + 'static {
+    // type Read: ?Sized;
+    /// Returns the type id of the trait object.
     fn get_trait_type_id() -> TraitTypeId;
 }