add a link to the RA bug

Author: lukesandberg

turbopack/crates/turbo-tasks/src/trait_ref.rs

@@ -1,4 +1,4 @@
-use std::{fmt::Debug, future::Future, marker::PhantomData};
+use std::{fmt::Debug, future::Future, marker::PhantomData, ptr::DynMetadata};
 
 use anyhow::Result;
 use serde::{Deserialize, Serialize};
@@ -72,6 +72,9 @@ impl<'de, T> Deserialize<'de> for TraitRef<T> {
     }
 }
 
+// This is a workaround for https://github.com/rust-lang/rust-analyzer/issues/19971
+// that ensures type inference keeps working with ptr_metadata.
+
 #[cfg(rust_analyzer)]
 impl<U> std::ops::Deref for TraitRef<Box<U>>
 where
@@ -81,7 +84,7 @@ where
     type Target = U;
 
     fn deref(&self) -> &Self::Target {
-        unimplemented!()
+        unimplemented!("only exists for rust-analyzer type inference")
     }
 }
 

turbopack/crates/turbo-tasks/src/value_type.rs

@@ -197,6 +197,7 @@ impl ValueType {
         self.traits.insert(trait_type, meta);
     }
 
+    /// Composes a fat pointer from a `dyn Any` for the given trait_id
     pub(crate) fn as_trait_ptr<T>(
         &self,
         trait_type: TraitTypeId,

turbopack/crates/turbopack-core/src/issue/mod.rs

@@ -861,7 +861,7 @@ impl PlainIssue {
         };
         let trait_ref = issue.into_trait_ref().await?;
 
-        let severity = (trait_ref).severity();
+        let severity = trait_ref.severity();
 
         Ok(Self::cell(Self {
             severity,