Apply suggestions from code review

Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>

Author: tdoublep

vllm/config/__init__.py

@@ -2440,7 +2440,7 @@ class LoRAConfig:
     bias_enabled: bool = False
     """[DEPRECATED] Enable bias for LoRA adapters. This option will be
     removed in v0.12.0."""
-    activated_lora_enabled: bool = False
+    enable_activated_lora: bool = False
     """Enable Activated LoRA."""
 
     def compute_hash(self) -> str:

vllm/engine/arg_utils.py

@@ -373,7 +373,7 @@ class EngineArgs:
     # LoRA fields
     enable_lora: bool = False
     enable_lora_bias: bool = LoRAConfig.bias_enabled
-    enable_activated_lora: bool = LoRAConfig.activated_lora_enabled
+    enable_activated_lora: bool = LoRAConfig.enable_activated_lora
     max_loras: int = LoRAConfig.max_loras
     max_lora_rank: int = LoRAConfig.max_lora_rank
     default_mm_loras: Optional[Dict[str, str]] = \
@@ -796,7 +796,7 @@ def add_cli_args(parser: FlexibleArgumentParser) -> FlexibleArgumentParser:
         lora_group.add_argument("--enable-lora-bias",
                                 **lora_kwargs["bias_enabled"])
         lora_group.add_argument("--enable-activated-lora",
-                                **lora_kwargs["activated_lora_enabled"])
+                                **lora_kwargs["enable_activated_lora"])
         lora_group.add_argument("--max-loras", **lora_kwargs["max_loras"])
         lora_group.add_argument("--max-lora-rank",
                                 **lora_kwargs["max_lora_rank"])
@@ -1372,7 +1372,7 @@ def create_engine_config(
 
         lora_config = LoRAConfig(
             bias_enabled=self.enable_lora_bias,
-            activated_lora_enabled=self.enable_activated_lora,
+            enable_activated_lora=self.enable_activated_lora,
             max_lora_rank=self.max_lora_rank,
             max_loras=self.max_loras,
             default_mm_loras=self.default_mm_loras,

vllm/lora/peft_helper.py

@@ -36,7 +36,7 @@ class PEFTHelper:
     # True to use Weight-Decomposed Low-Rank Adaptation (DoRA, see: https://arxiv.org/abs/2402.09353)
     use_dora: bool = field(default=False)
     # Invocation tokens for Activated LoRA (aLoRA, see: https://arxiv.org/abs/2504.12397)
-    alora_invocation_tokens: Optional[list[int]] = field(default=None)
+    alora_invocation_tokens: Optional[list[int]] = None
     # Extra vllm field, start with 'vllm_' to avoid conflict
     vllm_lora_scaling_factor: float = field(default=1.0)
     vllm_max_position_embeddings: Optional[int] = field(default=False)