fix: let uv replace the directory instead of deleting it ourselves (#981)

* fix: try harder to remove directories on failure

Signed-off-by: Henry Schreiner <[email protected]>

* fix: adjust permissions

Signed-off-by: Henry Schreiner <[email protected]>

* fix: warn and ignore PermissionsError

Signed-off-by: Henry Schreiner <[email protected]>

* fix: try os.remove

Signed-off-by: Henry Schreiner <[email protected]>

* fix: just warn on PermissionsError

Signed-off-by: Henry Schreiner <[email protected]>

* fix: ignore more errors

Signed-off-by: Henry Schreiner <[email protected]>

* fix: use uv's cleaning instead of doing it ourselves

Signed-off-by: Henry Schreiner <[email protected]>

* tests: coverage for uv env deletion

Signed-off-by: Henry Schreiner <[email protected]>

---------

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

nox/virtualenv.py

@@ -515,7 +515,9 @@ def _clean_location(self) -> bool:
                 and self._check_reused_environment_interpreter()
             ):
                 return False
-            shutil.rmtree(self.location, ignore_errors=True)
+            # uv clears it for us, and it balks at files left around
+            if self.venv_backend != "uv":
+                shutil.rmtree(self.location, ignore_errors=True)
         return True
 
     def _read_pyvenv_cfg(self) -> dict[str, str] | None:

tests/test_virtualenv.py

@@ -304,6 +304,9 @@ def test_uv_creation(
     venv.create()
     assert venv._check_reused_environment_type()
 
+    venv.create()
+    assert venv._check_reused_environment_type()
+
 
 @has_uv
 def test_uv_managed_python(