Skip to content

Commit 3bccb43

Browse files
Merge pull request #2 from yevheniidehtiar/feature/create-milestone
fix: Make state parameter required for createMilestone
2 parents ef2a684 + 6ee1133 commit 3bccb43

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

pkg/github/__toolsnaps__/create_milestone.snap

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@
3838
"required": [
3939
"owner",
4040
"repo",
41-
"title"
41+
"title",
42+
"state"
4243
],
4344
"type": "object"
4445
},

pkg/github/issues.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,7 @@ func CreateMilestone(getClient GetClientFn, t translations.TranslationHelperFunc
227227
mcp.Description("Milestone title"),
228228
),
229229
mcp.WithString("state",
230+
mcp.Required(),
230231
mcp.Description("Milestone state"),
231232
mcp.Enum("open", "closed"),
232233
),

pkg/github/issues_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ func Test_CreateMilestone(t *testing.T) {
136136
assert.Contains(t, tool.InputSchema.Properties, "state")
137137
assert.Contains(t, tool.InputSchema.Properties, "description")
138138
assert.Contains(t, tool.InputSchema.Properties, "due_on")
139-
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner", "repo", "title"})
139+
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner", "repo", "title", "state"})
140140

141141
// Setup mock milestone for success case
142142
dueOn, _ := time.Parse(time.RFC3339, "2025-01-01T00:00:00Z")

0 commit comments

Comments
 (0)