Skip to content

Conversation

zendesk-punavwalke
Copy link
Contributor

💐

/cc @zendesk/wattle

Description

The PR changes includes referential integrity translation changes in this [PR](The PR changes includes new translations for cov2 validations)

References

JIRA

Before merging this PR

  • Fill out the Risks section
  • Think about performance and security issues

Risks

  • [RUNTIME] Can this change affect apps rendering for a user?
    No, it cannot affect apps rendering. These validation runs during in zip validation
  • [HIGH | medium | low] What features does this touch?
    medium: Right now, it does not touch any existing feature. We are introducing a new resource_type which is not yet used in ZAM or any of the existing apps.

@zendesk-punavwalke zendesk-punavwalke marked this pull request as ready for review September 16, 2025 13:11
@zendesk-punavwalke zendesk-punavwalke requested a review from a team as a code owner September 16, 2025 13:11
screenshot: "https://drive.google.com/file/d/124uX-MBnEoqt7lDZBqQb4OVT2YN8-qz2/view?usp=sharing"
- translation:
key: "txt.apps.admin.error.app_build.invalid_cov2_object_reference_in_triggers"
title: "App builder job: requirements file contains an invalid object reference in object_triggers for Custom Objects V2. Leave requirements.json,object_triggers, Trigger and objects as is (do not translate)"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "App builder job: requirements file contains an invalid object reference in object_triggers for Custom Objects V2. Leave requirements.json,object_triggers, Trigger and objects as is (do not translate)"
title: 'App builder job: requirements file contains an invalid object reference in object_triggers for Custom Objects V2. Do not translate "requirements.json", "object_fields", \"%{item_identifier}\", \"%{object_key}\".'

@alok2806 alok2806 added the g11n-approved Approved by Globalization label Sep 17, 2025
Copy link
Contributor

@digesh-parecha digesh-parecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comments

@@ -221,6 +221,16 @@ parts:
title: "App builder job: requirements file contains an empty hash for custom objects v2. Leave requirements.json as is (do not translate)"
value: "The requirements.json file contains empty custom objects v2 requirements. You must define valid requirements."
screenshot: "https://drive.google.com/file/d/1AfbKu_JOMSG9274IUrIUvwirSuwbxy3Y/view?usp=sharing"
- translation:
key: "txt.apps.admin.error.app_build.invalid_cov2_object_reference_in_fields"
title: 'App builder job: requirements file contains an invalid object reference in object_fields for Custom Objects V2. Do not translate "requirements.json", "object_fields", \"%{item_identifier}\", \"%{object_key}\".'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra space.

@zendesk-punavwalke zendesk-punavwalke force-pushed the zendesk-punavwalke/translation-for-object-reference-error branch from 518dad7 to f9a7fce Compare September 17, 2025 08:27
@zendesk-punavwalke zendesk-punavwalke merged commit 894a17f into main Sep 17, 2025
5 checks passed
@zendesk-punavwalke zendesk-punavwalke deleted the zendesk-punavwalke/translation-for-object-reference-error branch September 17, 2025 08:30
zendesk-punavwalke added a commit that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
g11n-approved Approved by Globalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants