Skip to content

Minor refactor the operation type to the unify token kind #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2024
Merged

Minor refactor the operation type to the unify token kind #115

merged 1 commit into from
Dec 27, 2024

Conversation

git-hulk
Copy link
Member

It's no need to differ the type between the operation type and token kind.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12514419827

Details

  • 95 of 98 (96.94%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.351%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_column.go 31 32 96.88%
parser/parser_query.go 3 4 75.0%
parser/parser_table.go 18 19 94.74%
Totals Coverage Status
Change from base Build 12502657335: 0.0%
Covered Lines: 6396
Relevant Lines: 10598
💛 - Coveralls

@git-hulk git-hulk requested a review from Lance726 December 27, 2024 09:51
@git-hulk git-hulk merged commit 72b088c into AfterShip:master Dec 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lance726 Lance726 Lance726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@git-hulk @coveralls @Lance726