Fix missing the table name visitor in CREATE/ALTER table #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

git-hulk merged 1 commit into AfterShip:master from git-hulk:fix/table-visitor

May 8, 2025

Member

git-hulk commented May 8, 2025

This closes #134.


          Fix missing the table name visitor in CREATE/ALTER table

891c1a5

git-hulk requested review from Copilot and Lance726

May 8, 2025 04:07

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Pull Request Overview

This pull request addresses the issue of the missing visitor call for the table name in both CREATE and ALTER table AST nodes.

Added a visitor call for a.TableIdentifier in the AlterTable Accept method.
Added a visitor call for c.Name in the CreateTable Accept method.

coveralls commented May 8, 2025

Pull Request Test Coverage Report for Build 14898400583

Details

2 of 6 (33.33%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 62.73%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
parser/ast.go	2	6	33.33%

Totals
Change from base Build 14897009431:	-0.02%
Covered Lines:	6931
Relevant Lines:	11049

💛 - Coveralls

Lance726 approved these changes

View reviewed changes

git-hulk merged commit 6c8af70 into AfterShip:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet