[ Bug Fix ] Preserve DISTINCT keyword when it appears right after SELECT #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the SQL parser where the
DISTINCT
keyword was being lost during parsing and reconstruction when it appears right after theSELECT
keyword. For example:Note that this fix only affects the case where
DISTINCT
appears right afterSELECT
. The parser already correctly handlesDISTINCT
in other contexts, such as in aggregate functions:Changes
HasDistinct
field toSelectQuery
structparseSelectStmt
to store the DISTINCT informationString()
method to include DISTINCT in the outputTesting
Added test cases to verify that:
SELECT DISTINCT record_id FROM records
preserves the DISTINCT keywordSELECT count(DISTINCT(RECORD_ID)) FROM RECORD_TABLE
continues to work as before