Fix shouldn't stop on nil
values when traversing the AST
#191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as a bug fix the
Walk
function. It skips traversing constraints ifRight
isnil
clickhouse-sql-parser/parser/walk.go
Line 193 in 294aafb
clickhouse-sql-parser/parser/walk.go
Line 11 in 294aafb
This PR tries a more generic approach to prevent this bug and others by returning
true
if the node isnil
.I also added a test that fails without this fix