Update the progressive parameter in the KYC session creation API to use a boolean type (#10632)

Co-authored-by: Vlad Olaru <[email protected]>

Author: mordeth

changelog/fix-session-creation-eligibility-type

@@ -0,0 +1,4 @@
+Significance: patch
+Type: dev
+
+Updated the progressive parameter in the KYC session creation API to use a boolean type.

includes/admin/class-wc-rest-payments-onboarding-controller.php

@@ -59,7 +59,9 @@ public function register_routes() {
 					'progressive'     => [
 						'required'    => false,
 						'description' => 'Whether the session is for progressive onboarding.',
-						'type'        => 'string',
+						// phpcs:ignore Squiz.PHP.CommentedOutCode.Found
+						// We expect a boolean (true, false, 0, 1, '0', '1', 'true', or 'false'), but will also accept `yes`/`no`.
+						'type'        => [ 'boolean', 'string' ],
 					],
 					'self_assessment' => [
 						'required'    => false,
@@ -228,7 +230,7 @@ public function register_routes() {
 	 */
 	public function get_embedded_kyc_session( WP_REST_Request $request ) {
 		$self_assessment_data = ! empty( $request->get_param( 'self_assessment' ) ) ? wc_clean( wp_unslash( $request->get_param( 'self_assessment' ) ) ) : [];
-		$progressive          = ! empty( $request->get_param( 'progressive' ) ) && 'true' === $request->get_param( 'progressive' );
+		$progressive          = ! empty( $request->get_param( 'progressive' ) ) && filter_var( $request->get_param( 'progressive' ), FILTER_VALIDATE_BOOLEAN );
 
 		$account_session = $this->onboarding_service->create_embedded_kyc_session(
 			$self_assessment_data,