Update the progressive parameter in the KYC session creation API to use a boolean type #10632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
oaratovskyi
reviewed
Mar 26, 2025
There was a problem hiding this comment.
That makes sense to me, @mordeth !
This change will be released on Apr, 9 so I guess that we should be good when it's used in WC Core 9.9.
However, if the old version of WooPayments is installed (that uses string), then it might be an issue. Will Core handle this BC nuance?
|
Great question, Oleks! The In-context onboarding will only be available for new stores without onboarded accounts. If the WooPayments version is older than 9.2, we’ll fall back to the original external onboarding flow via redirect. |
oaratovskyi
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR updates the type of the progressive parameter in the KYC session creation API to boolean. This change ensures compatibility with the implementation introduced in Add NOX in-context APIs, where the parameter is now expected to be a boolean value.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge