-
Notifications
You must be signed in to change notification settings - Fork 2k
Notifications v2: implement note list and note details shortcuts #105578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested but I found the t
didn't work 🤔
import getIsLoading from '../../panel/state/selectors/get-is-loading'; | ||
import getKeyboardShortcutsEnabled from '../../panel/state/selectors/get-keyboard-shortcuts-enabled'; | ||
import { useAppContext } from '../context'; | ||
import './style.scss'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we don't need this 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad copy-paste, fixed in 6307bd9.
bc8165e
to
6307bd9
Compare
Good catch, fixed in edb5c86 🤦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again and looks good 👍
Fixes DOTCOM-14291
Proposed Changes
Implement the following shortcuts in notifications v2:
From note list
From note details
a
: approves
: mark as spamt
: move to the trashl
: likee
: editAfter
s
andt
, we will go back to the note list, and focus will be set to the next note.Testing Instructions
Pre-merge Checklist