-
Notifications
You must be signed in to change notification settings - Fork 2k
Domains: Show the proper columns in domains list #105594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice job splitting up the logic. I've left just one question.
return ( | ||
<HStack justify="flex-start" alignment="center" spacing={ 1 }> | ||
{ ! isCompact && ( | ||
<Icon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️ @ollierozdarz, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a57b5cf
to
559fd4e
Compare
Part of DOTDASH-190
Proposed Changes
Why are these changes being made?
Testing Instructions
/v2/domains
Pre-merge Checklist