Skip to content

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented Sep 5, 2025

Part of DOTDASH-190

Proposed Changes

  • Matches the domains table configuration with the Figma design
  • Removes the Site column from the site context domains table
  • Shows SSL column
  • Creates dedicated field template files for easier maintenance

Why are these changes being made?

Testing Instructions

  • Go to /v2/domains
  • Check the domains table
  • Select a site and go to the domains card
  • The domains table should not have Site column
Screenshot 2025-09-08 at 13 09 14 Screenshot 2025-09-08 at 13 29 32

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bogiii bogiii requested a review from a team September 5, 2025 12:21
@bogiii bogiii self-assigned this Sep 5, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 5, 2025
Copy link

github-actions bot commented Sep 5, 2025

@bogiii bogiii changed the title Update/dotdash 190 Domains: Show the proper columns in domains list Sep 5, 2025
@bogiii bogiii marked this pull request as ready for review September 8, 2025 11:29
@bogiii bogiii requested a review from a team as a code owner September 8, 2025 11:29
Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job splitting up the logic. I've left just one question.

return (
<HStack justify="flex-start" alignment="center" spacing={ 1 }>
{ ! isCompact && (
<Icon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not really related to this PR. But I wonder whether we actually need this icon or not. Seems that this pattern is not used anywhere else, not even in the purchase list:

Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ @ollierozdarz, what do you think?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bogiii,

I've been working on finalizing this with @ramynasr the past few days. Can you please let me know if anything looks missing or weird in the Figma directly?

@bogiii bogiii force-pushed the update/DOTDASH-190 branch from a57b5cf to 559fd4e Compare September 9, 2025 15:28
@bogiii bogiii merged commit 7e30d40 into trunk Sep 9, 2025
12 checks passed
@bogiii bogiii deleted the update/DOTDASH-190 branch September 9, 2025 16:15
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants