Skip to content

Removed duplicated ids for group by tag #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Removed duplicated ids for group by tag #1883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/apis/list-of-apis/ko/runtime/api-list-tiles.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<div class="form-inline max-w-500">
<div class="d-block flex-grow">
<input type="search" class="form-control form-control-light" aria-label="Search APIs" placeholder="Search APIs" spellcheck="false"
data-bind="textInput: pattern" />
<input type="search" class="form-control form-control-light" aria-label="Search APIs" placeholder="Search APIs"
spellcheck="false" data-bind="textInput: pattern" />
<tag-input params="{ scope: 'apis', onChange: onTagsChange }"></tag-input>
</div>
<div class="form-group ml-auto">
<label for="groupByTag">Group by tag
<label>Group by tag
<div class="switch">
<input id="groupByTag" type="checkbox" data-bind="checked: $component.groupByTag">
<input type="checkbox" data-bind="checked: $component.groupByTag">
<span class="slider round"></span>
</div>
</label>
Expand Down
4 changes: 2 additions & 2 deletions src/components/apis/list-of-apis/ko/runtime/api-list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
<tag-input params="{ scope: 'apis', onChange: onTagsChange }"></tag-input>
</div>
<div class="form-group ml-auto">
<label for="groupByTag">Group by tag
<label>Group by tag
<div class="switch">
<input id="groupByTag" type="checkbox" data-bind="checked: $component.groupByTag">
<input type="checkbox" data-bind="checked: $component.groupByTag">
<span class="slider round"></span>
</div>
</label>
Expand Down
14 changes: 9 additions & 5 deletions src/components/operations/operation-list/ko/runtime/operation-list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
<tag-input params="{ scope: $component.tagScope, onChange: onTagsChange }"></tag-input>
</div>
<div class="form-group ml-auto">
<label for="groupByTag">Group by tag
<label>Group by tag
<div class="switch">
<input id="groupByTag" type="checkbox" data-bind="checked: $component.groupByTag">
<input type="checkbox" data-bind="checked: $component.groupByTag">
<span class="slider round"></span>
</div>
</label>
Expand Down Expand Up @@ -61,9 +61,11 @@
</div>
<div class="list">
<!-- ko foreach: { data: group.items, as: 'item' } -->
<div role="option" class="list-item table-preset-operations" data-bind="activate: $component.selectOperation, css: { 'selected': $component.selectedOperationName() === item.name }">
<div role="option" class="list-item table-preset-operations"
data-bind="activate: $component.selectOperation, css: { 'selected': $component.selectedOperationName() === item.name }">
<div class="http-method" data-bind="attr: { 'data-method': method }"></div>
<div data-bind="text: ($component.showUrlPath() ? item.urlTemplate : item.displayName), css: { 'text-truncate': !$component.wrapText(), 'text-wrap': $component.wrapText() }, attr: { title: ($component.showUrlPath() ? item.urlTemplate : item.displayName) }">
<div
data-bind="text: ($component.showUrlPath() ? item.urlTemplate : item.displayName), css: { 'text-truncate': !$component.wrapText(), 'text-wrap': $component.wrapText() }, attr: { title: ($component.showUrlPath() ? item.urlTemplate : item.displayName) }">
</div>
</div>
<!-- /ko -->
Expand Down Expand Up @@ -97,7 +99,9 @@
<div role="option" class="list-item table-preset-operations"
data-bind="activate: $component.selectOperation, css: { 'selected': $component.selectedOperationName() === item.name }">
<div class="http-method" data-bind="attr: { 'data-method': method }"></div>
<div data-bind="text: ($component.showUrlPath() ? item.urlTemplate : item.displayName), css: { 'text-truncate': !$component.wrapText(), 'text-wrap': $component.wrapText() }, attr: { title: ($component.showUrlPath() ? item.urlTemplate : item.displayName) }"></div>
<div
data-bind="text: ($component.showUrlPath() ? item.urlTemplate : item.displayName), css: { 'text-truncate': !$component.wrapText(), 'text-wrap': $component.wrapText() }, attr: { title: ($component.showUrlPath() ? item.urlTemplate : item.displayName) }">
</div>
</div>
<!-- /ko -->
</div>
Expand Down