Skip to content

Implementing function metadata transform support #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

Implementing function metadata transform support #3145

merged 2 commits into from
Sep 17, 2025

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Aug 8, 2025 •
edited
Loading

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Rough draft of feature to allow augmentation of the FunctionMetadata.

Works E2E with: Azure/azure-functions-mcp-extension#88

@liliankasem liliankasem mentioned this pull request Aug 8, 2025
Closed
5 tasks
liliankasem
liliankasem commented Aug 11, 2025
View reviewed changes
@jviau
Copy link
Contributor

jviau commented Aug 25, 2025

Interesting approach. We should discuss this a bit more. I have an existing draft PR (#2834) and issue (#1159) that this approach would also address.

@fabiocav fabiocav force-pushed the liliankasem/metadata-transform branch from 4878b2e to ea11f59 Compare September 17, 2025 18:38
@fabiocav fabiocav force-pushed the liliankasem/metadata-transform branch from ea11f59 to d2cc574 Compare September 17, 2025 18:42
@fabiocav fabiocav marked this pull request as ready for review September 17, 2025 18:42
aishwaryabh
aishwaryabh reviewed Sep 17, 2025
View reviewed changes
@fabiocav fabiocav force-pushed the liliankasem/metadata-transform branch from d2cc574 to c71a5a9 Compare September 17, 2025 21:23
mattchenderson
mattchenderson approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@mattchenderson mattchenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR should be retitled / commit message for squash-and-merge should be adjusted so that history does not include a reference to a type not being included.

@fabiocav fabiocav changed the title Implement CompositeFunctionMetadataProvider to allow metadata transformation Implementing function metadata transform support Sep 17, 2025
@fabiocav fabiocav force-pushed the liliankasem/metadata-transform branch from c71a5a9 to 6fc8787 Compare September 17, 2025 21:30
@jviau
Copy link
Contributor

jviau commented Sep 17, 2025

Need to make sure to update AspNetCore extension to consume IFunctionMetadataManager and not the provider.

@fabiocav fabiocav merged commit 06e6302 into main Sep 17, 2025
28 checks passed
@fabiocav fabiocav deleted the liliankasem/metadata-transform branch September 17, 2025 22:26
This was referenced Sep 19, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocav fabiocav fabiocav left review comments

@jviau jviau jviau approved these changes

@mattchenderson mattchenderson mattchenderson approved these changes

@aishwaryabh aishwaryabh aishwaryabh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liliankasem @jviau @fabiocav @mattchenderson @aishwaryabh