-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Storage Discovery General Availability Release #28571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR marks the general availability (GA) release of the Az.StorageDiscovery module, transitioning from public preview to version 1.0.0. The changes include version updates, dependency upgrades, comprehensive test implementations, and module structure improvements.
Key changes:
- Updates module version to 1.0.0 and bumps Az.Accounts dependency to 5.3.0
- Implements comprehensive test coverage for all workspace cmdlets with proper test infrastructure
- Updates API version from preview to stable and corrects type references in help documentation
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
ChangeLog.md | Adds GA release entry for version 1.0.0 |
Az.StorageDiscovery.psd1 | Updates module metadata and dependency version |
StorageDiscovery.sln | Restructures solution file for updated project references |
help/*.md | Updates type references and documentation format |
test/*.ps1 | Implements comprehensive test coverage for all cmdlets |
test/*.json | Adds test environment configuration and recordings |
UX/storageDiscoveryWorkspaces.json | Updates API version from preview to stable |
custom/autogen-model-cmdlets/*.ps1 | Corrects type references for consistency |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems missing the change of file "src/StorageDiscovery/StorageDiscovery.Autorest/tsp-location.yaml"
You need to first raise PR to update tspconfig.yaml in TSP, then regenerate PSH code for tspconfig.yaml in public repo, then raise (update) this PR.
|
We have already get approval for StorageDiscovery GA in PSH/CLI with mail. |
Updated; regenerated with merged remote tspconfig.yaml. The commitID here updated accordingly. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
--> | ||
## Upcoming Release | ||
|
||
## Version 1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move change log right under "upcoming release"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please always add changelog to "Upcoming Release".
Azure Powershell team will update the version in the changelog later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. Thanks for the heads up.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1502
Public Preview PR: #28263
target to release on 10/14.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.