Skip to content

Conversation

shanefujs
Copy link
Member

Design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1502

Public Preview PR: #28263

target to release on 10/14.

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings September 17, 2025 01:34
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR marks the general availability (GA) release of the Az.StorageDiscovery module, transitioning from public preview to version 1.0.0. The changes include version updates, dependency upgrades, comprehensive test implementations, and module structure improvements.

Key changes:

  • Updates module version to 1.0.0 and bumps Az.Accounts dependency to 5.3.0
  • Implements comprehensive test coverage for all workspace cmdlets with proper test infrastructure
  • Updates API version from preview to stable and corrects type references in help documentation

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ChangeLog.md Adds GA release entry for version 1.0.0
Az.StorageDiscovery.psd1 Updates module metadata and dependency version
StorageDiscovery.sln Restructures solution file for updated project references
help/*.md Updates type references and documentation format
test/*.ps1 Implements comprehensive test coverage for all cmdlets
test/*.json Adds test environment configuration and recordings
UX/storageDiscoveryWorkspaces.json Updates API version from preview to stable
custom/autogen-model-cmdlets/*.ps1 Corrects type references for consistency

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly self-assigned this Sep 17, 2025
Copy link
Member

@blueww blueww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems missing the change of file "src/StorageDiscovery/StorageDiscovery.Autorest/tsp-location.yaml"

You need to first raise PR to update tspconfig.yaml in TSP, then regenerate PSH code for tspconfig.yaml in public repo, then raise (update) this PR.

@VeryEarly
Copy link
Collaborator

VeryEarly commented Sep 17, 2025

  • GA process is handled by Azure-PowerShell team, please contact us from teams channel or email
  • move change log right under "upcoming release"
  • This PR is intended to upgrade API version from “2025-06-01-preview” to "2025-09-01", please update tsp-location.yml to reference upgraded specs

@blueww
Copy link
Member

blueww commented Sep 17, 2025

@VeryEarly

We have already get approval for StorageDiscovery GA in PSH/CLI with mail.
Just included you in the mail with title "GA release for Az.StorageDiscovery"

@shanefujs
Copy link
Member Author

Seems missing the change of file "src/StorageDiscovery/StorageDiscovery.Autorest/tsp-location.yaml"

You need to first raise PR to update tspconfig.yaml in TSP, then regenerate PSH code for tspconfig.yaml in public repo, then raise (update) this PR.

Updated; regenerated with merged remote tspconfig.yaml. The commitID here updated accordingly.

@shanefujs shanefujs requested a review from blueww September 17, 2025 15:13
@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

-->
## Upcoming Release

## Version 1.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move change log right under "upcoming release"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shanefujs

Please always add changelog to "Upcoming Release".
Azure Powershell team will update the version in the changelog later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. Thanks for the heads up.

@shanefujs shanefujs requested a review from VeryEarly September 18, 2025 14:43
@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants