[Feedback Request] What do you think of MSAL 3.0.0-preview?

[jmprieur]

We just released MSAL.NET 3.0.0-preview

See https://aka.ms/msal-net-3x for details.

We'd like to get your feedback

In particular on:

• the new fluent API
• do you prefer it to the many overrides?
• would you be happy if we removed the old-style MSAL 2.x overrides and only kept the fluent API?
• the proposed deprecation plan for the non-fluent API
• the proposed support/deprecation plan for the MSAL 2.x cache format

Feel free to respond to this issue with your feedback on recommendations

[dansiegel]

@jmprieur I do like the new fluent API in 3.0... I do not like that it is still expecting the UIParent which is really more relevant for Android as I recall from our previous conversations. This should be moved to PublicClientApplicationBuilder where specifically for Android you should add WithActivity. This means that the PCA can be built at the Platform level and injected with DI... everything after that should work great.

[bgavrilMS]

Hi @dansiegel - thanks for the feedback. We also feel the acquire token silent needs work. It's not trivial to come up with the right API here because on Android devs need to pass in the Authority. On other platforms a parent window can be used simply so that we can center the webui.

We discuss this in more detail, along with an API proposal, here:

#918

[jmprieur]

See also #949 and #918 (comment)

[HappyNomad]

I'm beginning with MSAL and haven't experienced the 2.0 API. From what I can tell, the 3.0 one is better and more flexible. In the interest of those improvements, and to make the current API less crowded, please depreciate the 2.0 members in the 3.0 release and outright remove them in 4.0.

[HappyNomad]

I found only this sample that's for AD B2C and uses the MSAL v3 API. Does it reflect best practices? I have some doubts that I asked about here and here.

[jmprieur]

@ChainReactive
thanks for the feedback.
B2C is a bit special (as the notion of policy does not appear directly in the API model), and we are a bit behind on updating the B2C samples, but that's definitively something we are working on. See for instance this issue (#911), and also this branch (https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/tree/jennyf/b2cPrototype) where @jennyf19 where we are discussing surfacing B2C policies as a first class concept in the API.

[zedthehead]

I found only this sample that's for AD B2C and uses the MSAL v3 API. Does it reflect best practices? I have some doubts that I asked about here and here.

There's a pretty good sample that's just been updated to v3 here : https://github.com/Azure-Samples/active-directory-dotnet-admin-restricted-scopes-v2

[zedthehead]

Any examples anywhere of calling SharePoint Online search API using MSAL v3?

[jmprieur]

All the Azure AD samples are available from https://aka.ms/aaddevsamplesv2 and all the .NET one use the new MSAL 3.x API.

There are a few B2C samples using MSAL.NET 3.x already

• https://github.com/Azure-Samples/active-directory-b2c-dotnet-desktop
• https://github.com/Azure-Samples/active-directory-b2c-xamarin-native
• https://github.com/Azure-Samples/active-directory-b2c-dotnetcore-webapp
  We have been working on updating the other B2C samples to MSAL 3.x

For SharePoint online search API, what is the name of the resource @zedthehead ? can you see it in the app registration portal: https://docs.microsoft.com/en-us/azure/active-directory/develop/quickstart-configure-app-access-web-apis#add-permissions-to-access-web-apis ?

[dansiegel]

Does it reflect best practices?

@ChainReactive I would tend to say overwhelmingly the norm of Microsoft samples... assume they're following worst practices for a Proof of Concept.

[zedthehead]

In the api permissions page it is listed as Sites.Search.All under the SharePoint sub-heading/group. The name of the scope is given as https://microsoft.sharepoint-df.com/Sites.Search.All. Currently I'm trying to port an ASP.NET MVC5 project from ADAL to MSAL v3 using the https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/url sample as a guide

[jmprieur]

@zedthehead
you can get inspired by this sample: https://github.com/Azure-Samples/active-directory-dotnet-admin-restricted-scopes-v2/blob/master/GroupManager/Controllers/GroupsController.cs (MVC5)

If you want to move to ASP.NET core, this one is even bettre: https://github.com/Azure-Samples/ms-identity-aspnetcore-webapp-tutorial, in particular https://github.com/Azure-Samples/ms-identity-aspnetcore-webapp-tutorial/blob/master/3-WebApp-multi-APIs/Controllers/HomeController.cs#L42