Little fix for NetSpec: allow setting top blob names using string #3747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, the dictionary style NetSpec is definitely useful in these cases and we've done this in side branches without trouble. Thanks for the patch! |
shelhamer
added a commit
that referenced
this pull request
Feb 29, 2016
[pycaffe] NetSpec: set tops by attribute or dictionary
fxbit
pushed a commit
to Yodigram/caffe
that referenced
this pull request
Sep 1, 2016
[pycaffe] NetSpec: set tops by attribute or dictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some top blob names (ex. in GoogleNet) contain symbols that can't be used in python variable name.
This patch allows the following:
The patch is just a simple workaround that doesn't break original NetSpec style to specify top names