Skip to content

Python 3.13 #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

Python 3.13 #231

merged 1 commit into from
Feb 11, 2025

Conversation

johnnynunez
Copy link
Contributor

minimum python also

@thewtex thewtex requested review from Copilot and iMichka February 11, 2025 19:43
Copilot
Copilot AI reviewed Feb 11, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@thewtex thewtex merged commit cc46508 into CastXML:develop Feb 11, 2025
8 checks passed
@iMichka
Copy link
Collaborator

iMichka commented Feb 12, 2025

This looks good, but we do not test these versions in CI.
I would have expected to have the removal from Python 3.7 to 3.8 in this PR, and the addition of CI for Python 3.11, 3.12, 3.13.
Can this be done too in a follow up PR?

@iMichka
Copy link
Collaborator

iMichka commented Feb 13, 2025

Done with #233 @johnnynunez

@johnnynunez
Copy link
Contributor Author

This looks good, but we do not test these versions in CI. I would have expected to have the removal from Python 3.7 to 3.8 in this PR, and the addition of CI for Python 3.11, 3.12, 3.13. Can this be done too in a follow up PR?

I open 2 PR's arm and use artifacts. they are working for me now with CASTXML 0.6.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@thewtex thewtex thewtex approved these changes

@iMichka iMichka Awaiting requested review from iMichka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnnynunez @iMichka @thewtex