Revert commits breaking API and binary OCPP 1.6 passwords #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These commits were based on a misunderstanding of the OCPP-J 1.6 specification, which clearly states that the password is a byte sequence and not a string: Revert "More password fixes." This reverts commit fb5d0fb. Revert "Fix password decoding." This reverts commit cf20205. Revert "Recommended by 1.6 spec is a 20 byte (40 chars) key." This reverts commit f7b92a3. This commit breaks the API, because the behaviour of the method is changed to return the last configuration instead of the default configuration: Revert "A single instace, otherwise a static get() method makes no sense." This reverts commit 953f50b.
|
This PR reverts the repository back to the state as of commit 14d60bc (Update gson), which was the only valid commit in the series. The other ones only broke things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits were based on a misunderstanding of the OCPP-J 1.6 specification, which clearly states that the password is a byte sequence and not a string. Also, they broke the ServerEvents#authenticateSession() API:
Revert "More password fixes."
This reverts commit fb5d0fb.
Revert "Fix password decoding."
This reverts commit cf20205.
Revert "Recommended by 1.6 spec is a 20 byte (40 chars) key."
This reverts commit f7b92a3.
This commit breaks the API, because the behaviour of the method is changed to return the last configuration instead of the default configuration:
Revert "A single instace, otherwise a static get() method makes no sense."
This reverts commit 953f50b.