Skip to content

refactor(selection-tools): remove redundant getPreferredLanguage calls #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023
Merged

refactor(selection-tools): remove redundant getPreferredLanguage calls #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/content-script/selection-tools/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ const createGenPrompt =
includeLanguagePrefix = false,
}) =>
async (selection) => {
const preferredLanguage = isTranslation ? targetLanguage : await getPreferredLanguage()
let preferredLanguage = targetLanguage

if (!preferredLanguage) {
preferredLanguage = await getPreferredLanguage()
}

let fullMessage = isTranslation
? `Translate the following into ${preferredLanguage} and only show me the translated content`
: message
Expand All @@ -45,7 +50,6 @@ export const config = {
label: 'Translate',
genPrompt: createGenPrompt({
isTranslation: true,
targetLanguage: await getPreferredLanguage(),
}),
},
translateToEn: {
Expand All @@ -69,7 +73,6 @@ export const config = {
label: 'Translate (Bidirectional)',
genPrompt: createGenPrompt({
isTranslation: true,
targetLanguage: await getPreferredLanguage(),
enableBidirectional: true,
}),
},
Expand Down