Skip to content

Conversation

sribhavan47
Copy link

@sribhavan47 sribhavan47 commented Jun 24, 2025

PR Description

This PR adds a full implementation of the B92 Quantum Key Distribution (QKD) protocol to the classiq-library, complementing the existing BB84 protocol.

Key additions:

  • New B92 QKD circuit and supporting functions
  • Example notebook or script demonstrating B92 usage
  • metadata.json for discoverability and consistency

Highlights:

  • Uses single-qubit states |0⟩ and |+⟩ for encoding, per B92 specifications.
  • Includes measurement and basis selection logic for Bob.
  • Demonstrates key sifting and potential error checking.

Related Issue

Closes #1026

Checklist

  • Implemented core B92 protocol logic.
  • Added metadata.json.
  • Provided example usage.
  • Added basic documentation and comments.
  • Verified integration with the library.

Please @NadavClassiq review and let me know if any improvements or tests are recommended!

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Bhavan added 2 commits June 26, 2025 14:48
- Tightened the markdown and checked the bullet point format
- Replaced image file using drag and drop from the project.
@sribhavan47
Copy link
Author

hi @NadavClassiq, I have addressed all the reviews you have suggested, please do review it. Please let me know if any further changes or clarifications are needed, happy to make adjustments!

@sribhavan47 sribhavan47 requested a review from NadavClassiq June 27, 2025 06:25
@NadavClassiq
Copy link
Collaborator

Hi @sribhavan47,
Please see mt additional comment regarding producing a valid key.
Also, follow the error message to resolve the Lint failure.

@NadavClassiq
Copy link
Collaborator

Hi @sribhavan47,
Please take a look at the additional comment about producing a valid key.
Also, follow the error message to resolve the Lint failure.

We will have to close this PR if no action is taken in the next few days.

Thanks in advance!

@NadavClassiq NadavClassiq self-assigned this Aug 7, 2025
@NadavClassiq NadavClassiq added the Paper Implementation Project Implement a paper using Classiq label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paper Implementation Project Implement a paper using Classiq
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing The B92 Quantum Key Distribution Protocol
2 participants