Change projection days from a slider to a number input to allow larger max values #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshot of what it looks like as an input instead of a slider. |
|
Probably should go in the sidebar for consistency with all the other inputs. |
|
@cjbayesian I'm cool moving to the sider bar.
|
|
/cc @mdbecker and @quinn-dougherty This PR expanded a bit in scope than just resolving #199, and wanted to ping you if these changes are in-line to where you want to project to evolve to. |
quinn-dougherty
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the "Number of days to project" input from a slider to a number input. This allows users to set an exact value and to values greater than 200.
Some context about slider vs input from Slack
Closes #199
From comments, I also added to this PR to move the last few presentation UI elements to display in the sidebar and into the
Parametersmodel.Full screenshot of the changed UI.
