Add implied daily growth rate #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2020 18:49
…rameters` class. - Adds `daily_growth_helper` function to `src/penn_chime/parameters.py` to calculate daily growth rate as a function of doubling time. - Updates `display_header` function in `src/penn_chime/presentation.py` to display initial and mitigated daily growth rates. - Adds `test_daily_growth` test to `tests/test_app.py` to test above changes Fixes #90
ecsmyth
changed the title
|
Set to WIP. I neglected to add tests for the |
… to include test for daily growth when halving
ecsmyth
changed the title
|
Added tests for |
cjbayesian
approved these changes
Mar 24, 2020
|
@ecsmyth I'm pulling this out of the 1.0 release so that you can resolve the merge conflict. Thanks! |
mdbecker
requested changes
Mar 24, 2020
added 4 commits
March 24, 2020 19:35
…rameters` class. - Adds `daily_growth_helper` function to `src/penn_chime/parameters.py` to calculate daily growth rate as a function of doubling time. - Updates `display_header` function in `src/penn_chime/presentation.py` to display initial and mitigated daily growth rates. - Adds `test_daily_growth` test to `tests/test_app.py` to test above changes Fixes #90
ecsmyth
commented
Mar 25, 2020
|
Becker's requested change is just resolving merge conflicts, which are fine, so we're gonna merge in |
quinn-dougherty
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
daily_growthanddaily_growth_tinstance attributes onParametersclass.daily_growth_helperfunction tosrc/penn_chime/parameters.pyto calculate daily growth rate as a function of doubling time.display_headerfunction insrc/penn_chime/presentation.pyto display initial and mitigated daily growth rates.test_daily_growthtest totests/test_app.pyto test above changesFixes #90