Skip to content

Trim dockerfile #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2020
Merged

Trim dockerfile #275

merged 1 commit into from
Mar 26, 2020

Conversation

jlubken
Copy link
Collaborator

@jlubken jlubken commented Mar 26, 2020 •
edited
Loading

Remove COPY . ./ from Dockerfile. Only the python module is needed.

Closes #274

@jlubken jlubken self-assigned this Mar 26, 2020
themightychris
themightychris requested changes Mar 26, 2020
View reviewed changes
Copy link
Member

@themightychris themightychris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This renders the .dockerignore in the root as derelict code now, we should delete it now and that delete should be tied to this PR

themightychris
themightychris approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@themightychris themightychris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nvm I guess the .dockerignore would still get read and used to filter out certain file extensions under the copies trees. maybe it could be trimmed down now, but not a big deal

@quinn-dougherty quinn-dougherty merged commit 0a0aece into develop Mar 26, 2020
@quinn-dougherty quinn-dougherty deleted the trim_dockerfile branch March 26, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themightychris themightychris themightychris approved these changes

@machow machow Awaiting requested review from machow

@quinn-dougherty quinn-dougherty Awaiting requested review from quinn-dougherty

Assignees

@jlubken jlubken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trim Dockerfile
3 participants
@jlubken @themightychris @quinn-dougherty