-
Notifications
You must be signed in to change notification settings - Fork 151
makes census chart granular at daily level #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please merge in latest master in order to allow a side-by-side comparison of numbers with current prod. |
@cjbayesian Just merged the current master into this branch. |
Thanks, @fbenamy . This looks like it's going to work, but there is code currently in this branch that is not the latest in terms of how the initial infected population is being calculated. Specifically, this input should not be there: All of the code that is not related to just the census chart should not differ between this and master. |
That's very weird. I pulled from the Code for Philly master before merging. Let me do some digging and see what might be up with my local repo not staying current. |
So it looks like I somehow removed app.py from the merge commit. I just checked that the code is right in the online repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi -- the sidebar input order doesn't agree with prod. Unless there's an explanation for this i don't know about, could you please align the sidebars? they should look exactly the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the code. My apologies for all the back and forth errors. I just recently changed ides and managed to bungle the handling of merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, thanks!
Closes #11