Skip to content

ci: build the native addon in the linting step #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2023
Merged

ci: build the native addon in the linting step #287

merged 1 commit into from
Jan 19, 2023

Conversation

kyakdan
Copy link
Member

@kyakdan kyakdan commented Jan 19, 2023

This is needed so that CMake generates compile_commands.json, which is needed by clang-tidy

@kyakdan
ci: build the native addon in the linting step
c3ab70a 
This is needed so that CMake generates compile_commands.json that is
 needed by clang-tidy
@bertschneider
Copy link
Contributor

Now we know again why the fuzzer build was there 😄
I debugged this with @oetr yesterday as well, but only on his branch. A dedicated PR is a good idea!

@bertschneider bertschneider merged commit f76b748 into main Jan 19, 2023
@bertschneider bertschneider deleted the fix-linting-workflow branch January 19, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bertschneider bertschneider bertschneider approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyakdan @bertschneider