Streamline option handling #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertschneider
force-pushed
the
FUZZ-694_align_parameters
branch
2 times, most recently
from
a48c1f6 to
8d8f64f
Compare
br-lewis
approved these changes
Aug 2, 2023
oetr
reviewed
Aug 3, 2023
oetr
reviewed
Aug 3, 2023
oetr
reviewed
Aug 3, 2023
oetr
reviewed
Aug 3, 2023
bertschneider
force-pushed
the
FUZZ-694_align_parameters
branch
2 times, most recently
from
53ef33c to
8424be9
Compare
oetr
approved these changes
Aug 7, 2023
bertschneider
force-pushed
the
FUZZ-694_align_parameters
branch
from
8424be9 to
81f890e
Compare
"clean" will delete all node_modules and dist folders, and the fuzzer C++ build directories. Deleting all files mentioned in .gitignore files would work even better, but there does not seem to be a still maintained project for that.
Options are handled in a consistent way across CLI and Jest integration, so that both use the same names with the same semantics.
Yargs automatically converts numeric CLI arguments to numbers. As the fuzzer argument handling only expects strings, enforce the argument types.
bertschneider
force-pushed
the
FUZZ-694_align_parameters
branch
from
81f890e to
7d92256
Compare
The additional complexity does not add any value to the test and only prolongs the CI pipeline.
The test adds unnecessary long runtime to the CI pipeline. A more relaxed one tests the feature good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options are handled in a consistent way across CLI and the Jest integration, so that both use the same names with the same semantics.