-
Notifications
You must be signed in to change notification settings - Fork 33
Patch coverage of implicit else branches #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c35fa83
to
7c52b67
Compare
br-lewis
reviewed
Oct 9, 2023
tests/code_coverage/sample_fuzz_test/expected_coverage/fuzz+lib+codeCoverage-fuzz.json
Show resolved
Hide resolved
oetr
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
7c52b67
to
6ca5b32
Compare
The Jest integration tests start another Jest instance internally and assert that the fuzzer was able to raise findings or print expected output. As this may take up quite some time the timeout of the outer Jest instance is high, whereas the inner instance only executes a fixed number of runs.
6ca5b32
to
4aa4c7d
Compare
karfau
referenced
this pull request
in xmldom/xmldom
Oct 28, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@jazzer.js/core](https://togithub.com/CodeIntelligenceTesting/jazzer.js) | [`2.0.0` -> `2.1.0`](https://renovatebot.com/diffs/npm/@jazzer.js%2fcore/2.0.0/2.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>CodeIntelligenceTesting/jazzer.js (@​jazzer.js/core)</summary> ### [`v2.1.0`](https://togithub.com/CodeIntelligenceTesting/jazzer.js/releases/tag/v2.1.0): Release 2.1.0 [Compare Source](https://togithub.com/CodeIntelligenceTesting/jazzer.js/compare/v2.0.0...v2.1.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - **Feature**: Jest support: List fuzz test names by [@​zgtm](https://togithub.com/zgtm) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/606](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/606) - **Feature**: Handle real segfaults in fuzz targets by [@​br-lewis](https://togithub.com/br-lewis) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/602](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/602) - **Feature**: Provide consistent exit codes by [@​bertschneider](https://togithub.com/bertschneider) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/617](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/617) - **Bugfix**: Patch coverage of implicit else branches by [@​bertschneider](https://togithub.com/bertschneider) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/635](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/635) **Full Changelog**: CodeIntelligenceTesting/jazzer.js@v2.0.0...v2.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/xmldom/xmldom). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
karfau
referenced
this pull request
in xmldom/xmldom
Oct 28, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@jazzer.js/jest-runner](https://togithub.com/CodeIntelligenceTesting/jazzer.js) | [`2.0.0` -> `2.1.0`](https://renovatebot.com/diffs/npm/@jazzer.js%2fjest-runner/2.0.0/2.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>CodeIntelligenceTesting/jazzer.js (@​jazzer.js/jest-runner)</summary> ### [`v2.1.0`](https://togithub.com/CodeIntelligenceTesting/jazzer.js/releases/tag/v2.1.0): Release 2.1.0 [Compare Source](https://togithub.com/CodeIntelligenceTesting/jazzer.js/compare/v2.0.0...v2.1.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - **Feature**: Jest support: List fuzz test names by [@​zgtm](https://togithub.com/zgtm) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/606](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/606) - **Feature**: Handle real segfaults in fuzz targets by [@​br-lewis](https://togithub.com/br-lewis) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/602](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/602) - **Feature**: Provide consistent exit codes by [@​bertschneider](https://togithub.com/bertschneider) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/617](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/617) - **Bugfix**: Patch coverage of implicit else branches by [@​bertschneider](https://togithub.com/bertschneider) in [https://github.com/CodeIntelligenceTesting/jazzer.js/pull/635](https://togithub.com/CodeIntelligenceTesting/jazzer.js/pull/635) **Full Changelog**: CodeIntelligenceTesting/jazzer.js@v2.0.0...v2.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/xmldom/xmldom). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage of imported TS files was broken, see: istanbuljs/istanbuljs#705