-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Navigation Bar Drop Down Menus and Accessibility #2011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooohoo, this looks terrific! I am so excited to finally have some new organization to the site. I say let's merge and we can always adjust. The categories and naming all look great. I wonder if "streams" should be "live archive" or something else? But maybe "streams" is quite a conventional term. Thank you @violetcraze!
@violetcraze the navbar does not work on Mac using Safari. Could you cross check that? |
It doesn't work on Chrome either on my Mac. Only the Home button works as expected. |
Great work, @violetcraze! ^^ It's working for me - but only when you actually click the element. @gruselhaus / @shiffman / @phucduong86 have you tested hovering or clicking? Also adding a The "hand" could easily be fixed by applying |
Been working on adding drop down menus to the navigation bar. Open to feedback or suggestions. I'll leave this open for a couple days so people have an opportunity to check it out and make sure it looks good.
Worked off comment from #1759 for accessibility. Tested with the following:
fixes #1750
Here's some screenshots: