Skip to content
This repository was archived by the owner on Jul 5, 2022. It is now read-only.

Conversation

duskvirkus
Copy link
Member

Been working on adding drop down menus to the navigation bar. Open to feedback or suggestions. I'll leave this open for a couple days so people have an opportunity to check it out and make sure it looks good.

Worked off comment from #1759 for accessibility. Tested with the following:

fixes #1750

Here's some screenshots:

navbar1
navbar2
navbar3
navbar4
navbar5
navbar6
navbar7

Copy link
Member

@gruselhaus gruselhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@GypsyDangerous GypsyDangerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like these, the colors look good (though I didn't check them with a wcag color checker). Since you said you were able to do the accessibility tests and get the colors correct can you help me work on #1740 and #1759 sometime next year

Copy link
Member

@shiffman shiffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooohoo, this looks terrific! I am so excited to finally have some new organization to the site. I say let's merge and we can always adjust. The categories and naming all look great. I wonder if "streams" should be "live archive" or something else? But maybe "streams" is quite a conventional term. Thank you @violetcraze!

@duskvirkus duskvirkus merged commit ba779e4 into CodingTrain:master Dec 28, 2019
@duskvirkus duskvirkus deleted the navbar branch December 28, 2019 20:50
@gruselhaus
Copy link
Member

@violetcraze the navbar does not work on Mac using Safari. Could you cross check that?

@shiffman
Copy link
Member

I can confirm that it's not working on safari, don't seen anything in console.

Also, small thing but the "hand" doesn't appear when hovering the navbar as it does for other interactive elements on the page:

Screen Shot 2019-12-29 at 11 04 21 AM Screen Shot 2019-12-29 at 11 04 31 AM

@phucduong86
Copy link
Contributor

It doesn't work on Chrome either on my Mac. Only the Home button works as expected.
Looks like there was some regressions from the latest changes.

@vimkat
Copy link
Member

vimkat commented Dec 30, 2019

Great work, @violetcraze! ^^

It's working for me - but only when you actually click the element. @gruselhaus / @shiffman / @phucduong86 have you tested hovering or clicking? Also adding a onmouseover event would make it feel more natural to desktop users.

The "hand" could easily be fixed by applying cursor: pointer; to the respected HTML element in CSS. Then it also feels "clicky".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Issues related to WCAG compliance Enhancement Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is not easy to access content and core contribution guides on the website.
6 participants