`copilot-core`: Compliance with style guide (partial) (3)

[ivanperez-keera]

Description

To comply with our NASA Class D requirements, our code must abide by a style guide.

This is the third issue pertaining to style changes for conformance with Class D within copilot-core. We focus only on copilot-core to limit the size of the issue.

Type

• Management: conformance with new requirement.

Additional context

• See copilot-core: Compliance with style guide (partial) (2) #332 and Compliance with style guide (partial) #316 for other style changes addressed in copilot-core.

Requester

• Ivan Perez

Method to check presence of bug

Not applicable (not a bug).

Expected result

All Copilot code conforms to the following rules:

• Variable and function names should be lowerCamelCase.

Desired result

All code complies with the rules above.

Proposed solution

Deprecate Copilot.Core.Type.typename, Copilot.Core.Type.tylength, Copilot.Core.Type.tysize, Copilot.Core.Type.fieldname, Copilot.Core.Type.accessorname, Copilot.Core.Type.Array.arrayelems, and define corresponding functions with lowerCamelCase names.

Update all uses across all of copilot to match the new function names.

Further notes

These changes are public facing, they affect functions that are part of the API. We need to follow the deprecation policy for them.

[ivanperez-keera]

Change Manager: Confirmed that the style is non-conforming and further changes are needed.

[ivanperez-keera]

Technical Lead: Confirmed that the issue should be addressed.

[ivanperez-keera]

Technical Lead: Scheduled for fixing in Copilot 3.17.

Fix assigned to: @ivanperez-keera.