Skip to content

Fix #108 - Handle templated answers #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 18 commits into
base: development
Choose a base branch
from
Draft

Fix #108 - Handle templated answers #157

wants to merge 18 commits into from

Conversation

johnmarsden-edu
Copy link
Collaborator

No description provided.

@johnmarsden-edu johnmarsden-edu linked an issue Sep 4, 2025 that may be closed by this pull request
Implement faker randomization with challenge render and answer checker #108
Open
@johnmarsden-edu
Copy link
Collaborator Author

@fpayer, it's not done yet but does this look like what you were thinking?

johnmarsden-edu
johnmarsden-edu commented Sep 5, 2025
View reviewed changes
Copy link
Collaborator Author

@johnmarsden-edu johnmarsden-edu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, I'm making good progress, but I still need to write unit and integration tests to validate that the rendering is working the way I expect.

backend/ng/challenge/models/ContainerBlueprint.py
if isinstance(self.environment, list):
return self.environment

return {k: (v(team_seed) if isinstance(v, Callable) else v) for k, v in self.environment.items()}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to alias the callable to something that more clearly specifies that it's input is the team seed and the output is the seed for the variable.

backend/ng/event/controllers/admin/import_challenge_from_yaml.py

if TYPE_CHECKING:
from ....event.models.Event import Event

# TODO: Will this handle updating challenges as well?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is getting a bit larger than I prefer so I'll probably handle updating challenges in a separate PR after this one is merged.

fpayer
fpayer reviewed Sep 9, 2025
View reviewed changes
backend/ng/requirements.txt
@@ -14,4 +14,6 @@ gevent-websocket==0.10.1
types-Flask-SocketIO==5.5.0.20250809
#redis==6.2.0
docker==7.1.0
types-docker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pin to a specific version?

fpayer
fpayer approved these changes Sep 9, 2025
View reviewed changes
Copy link
Contributor

@fpayer fpayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is exactly what I was looking for!

Looks good to me. Just left a small comment about potentially pinning the version on the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpayer fpayer fpayer approved these changes

@Kiwi-CS Kiwi-CS Awaiting requested review from Kiwi-CS

@RayofLightz RayofLightz Awaiting requested review from RayofLightz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement faker randomization with challenge render and answer checker
2 participants
@johnmarsden-edu @fpayer