-
Notifications
You must be signed in to change notification settings - Fork 457
chore(iast): context refactor III #14513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 265 ± 2 ms. The average import time from base is: 268 ± 1 ms. The import time difference between this PR and base is: -3.31 ± 0.07 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate avara1986/APPSEC-58124_replace_context_map (f909b03) with baseline main (6f8f8a0) 📈 Performance Regressions (4 suites)📈 iast_aspects - 40/40✅ re_expand_aspectTime: ✅ 32.117µs (SLO: <40.000µs 📉 -19.7%) vs baseline: +0.7% Memory: ✅ 36.962MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% ✅ re_expand_noaspectTime: ✅ 28.462µs (SLO: <40.000µs 📉 -28.8%) vs baseline: -0.7% Memory: ✅ 37.021MB (SLO: <39.000MB -5.1%) vs baseline: +3.9% ✅ re_findall_aspectTime: ✅ 2.926µs (SLO: <10.000µs 📉 -70.7%) vs baseline: 📉 -24.2% Memory: ✅ 36.982MB (SLO: <39.000MB -5.2%) vs baseline: +3.8% ✅ re_findall_noaspectTime: ✅ 1.404µs (SLO: <10.000µs 📉 -86.0%) vs baseline: -0.7% Memory: ✅ 37.021MB (SLO: <39.000MB -5.1%) vs baseline: +3.8% ✅ re_finditer_aspectTime: ✅ 4.459µs (SLO: <10.000µs 📉 -55.4%) vs baseline: +0.8% Memory: ✅ 36.982MB (SLO: <39.000MB -5.2%) vs baseline: +3.7% ✅ re_finditer_noaspectTime: ✅ 1.400µs (SLO: <10.000µs 📉 -86.0%) vs baseline: -0.6% Memory: ✅ 36.982MB (SLO: <39.000MB -5.2%) vs baseline: +3.8% ✅ re_fullmatch_aspectTime: ✅ 2.684µs (SLO: <10.000µs 📉 -73.2%) vs baseline: ~same Memory: ✅ 36.982MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% ✅ re_fullmatch_noaspectTime: ✅ 1.292µs (SLO: <10.000µs 📉 -87.1%) vs baseline: ~same Memory: ✅ 36.962MB (SLO: <39.000MB -5.2%) vs baseline: +3.5% ✅ re_group_aspectTime: ✅ 2.942µs (SLO: <10.000µs 📉 -70.6%) vs baseline: +0.4% Memory: ✅ 36.962MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% ✅ re_group_noaspectTime: ✅ 1.613µs (SLO: <10.000µs 📉 -83.9%) vs baseline: -0.2% Memory: ✅ 36.962MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% ✅ re_groups_aspectTime: ✅ 3.102µs (SLO: <10.000µs 📉 -69.0%) vs baseline: +0.9% Memory: ✅ 37.002MB (SLO: <39.000MB -5.1%) vs baseline: +3.8% ✅ re_groups_noaspectTime: ✅ 1.714µs (SLO: <10.000µs 📉 -82.9%) vs baseline: +1.1% Memory: ✅ 36.962MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% ✅ re_match_aspectTime: ✅ 3.013µs (SLO: <10.000µs 📉 -69.9%) vs baseline: 📈 +11.5% Memory: ✅ 36.982MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% ✅ re_match_noaspectTime: ✅ 1.298µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -0.3% Memory: ✅ 36.962MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% ✅ re_search_aspectTime: ✅ 2.544µs (SLO: <10.000µs 📉 -74.6%) vs baseline: -0.5% Memory: ✅ 37.002MB (SLO: <39.000MB -5.1%) vs baseline: +3.9% ✅ re_search_noaspectTime: ✅ 1.198µs (SLO: <10.000µs 📉 -88.0%) vs baseline: -0.5% Memory: ✅ 36.962MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% ✅ re_sub_aspectTime: ✅ 3.448µs (SLO: <10.000µs 📉 -65.5%) vs baseline: +2.8% Memory: ✅ 36.982MB (SLO: <39.000MB -5.2%) vs baseline: +3.7% ✅ re_sub_noaspectTime: ✅ 1.538µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +1.1% Memory: ✅ 37.002MB (SLO: <39.000MB -5.1%) vs baseline: +3.8% ✅ re_subn_aspectTime: ✅ 3.700µs (SLO: <10.000µs 📉 -63.0%) vs baseline: +2.3% Memory: ✅ 36.962MB (SLO: <39.000MB -5.2%) vs baseline: +3.7% ✅ re_subn_noaspectTime: ✅ 1.623µs (SLO: <10.000µs 📉 -83.8%) vs baseline: +1.6% Memory: ✅ 37.002MB (SLO: <39.000MB -5.1%) vs baseline: +3.8% 📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.398µs (SLO: <10.000µs 📉 -96.0%) vs baseline: 📈 +20.4% Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: 📈 +21.9% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ add_inplace_noaspectTime: ✅ 0.318µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -0.6% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.0% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 1.354µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +1.9% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ bytearray_extend_aspectTime: ✅ 1.506µs (SLO: <10.000µs 📉 -84.9%) vs baseline: +9.4% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 0.616µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.6% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ bytearray_noaspectTime: ✅ 0.484µs (SLO: <10.000µs 📉 -95.2%) vs baseline: ~same Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.0% ✅ bytes_aspectTime: ✅ 1.305µs (SLO: <10.000µs 📉 -86.9%) vs baseline: +1.1% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ bytes_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.4% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7% ✅ bytesio_aspectTime: ✅ 1.353µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +3.1% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7% ✅ bytesio_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.1% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ capitalize_aspectTime: ✅ 0.739µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.6% Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.0% ✅ capitalize_noaspectTime: ✅ 0.434µs (SLO: <10.000µs 📉 -95.7%) vs baseline: +0.6% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ casefold_aspectTime: ✅ 0.741µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +1.1% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.1% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.0% ✅ decode_aspectTime: ✅ 0.722µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.6% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ decode_noaspectTime: ✅ 0.419µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.5% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.7% ✅ encode_aspectTime: ✅ 0.703µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.3% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7% ✅ encode_noaspectTime: ✅ 0.397µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.7% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7% ✅ format_aspectTime: ✅ 3.402µs (SLO: <10.000µs 📉 -66.0%) vs baseline: -0.5% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 3.547µs (SLO: <10.000µs 📉 -64.5%) vs baseline: 📈 +10.6% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7% ✅ format_map_noaspectTime: ✅ 0.772µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.7% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.6% ✅ format_noaspectTime: ✅ 0.592µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -1.2% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7% ✅ index_aspectTime: ✅ 0.354µs (SLO: <10.000µs 📉 -96.5%) vs baseline: +3.0% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ index_noaspectTime: ✅ 0.275µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.1% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 1.338µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +6.6% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ join_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.4% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 2.535µs (SLO: <20.000µs 📉 -87.3%) vs baseline: 📉 -76.8% Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.1% ✅ ljust_noaspectTime: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.5% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.6% ✅ lower_aspectTime: ✅ 2.248µs (SLO: <10.000µs 📉 -77.5%) vs baseline: +0.8% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ lower_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.4% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 2.232µs (SLO: <20.000µs 📉 -88.8%) vs baseline: 📉 -79.4% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.0% ✅ lstrip_noaspectTime: ✅ 0.387µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.5% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7% ✅ modulo_aspectTime: ✅ 1.047µs (SLO: <10.000µs 📉 -89.5%) vs baseline: 📈 +11.7% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.540µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +7.1% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8% ✅ modulo_aspect_for_bytesTime: ✅ 0.985µs (SLO: <10.000µs 📉 -90.1%) vs baseline: +7.5% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.6% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.242µs (SLO: <10.000µs 📉 -87.6%) vs baseline: 📈 +10.4% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8% ✅ modulo_noaspectTime: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +0.2% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ replace_aspectTime: ✅ 4.973µs (SLO: <10.000µs 📉 -50.3%) vs baseline: +6.1% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 0.457µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.4% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 0.909µs (SLO: <10.000µs 📉 -90.9%) vs baseline: ~same Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.417µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.9% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.6% ✅ rstrip_aspectTime: ✅ 1.926µs (SLO: <20.000µs 📉 -90.4%) vs baseline: 📉 -82.0% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.1% ✅ rstrip_noaspectTime: ✅ 0.383µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.7% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +1.3% Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.447µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.3% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.9% ✅ stringio_aspectTime: ✅ 1.530µs (SLO: <10.000µs 📉 -84.7%) vs baseline: -0.1% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 0.713µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.5% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 2.215µs (SLO: <20.000µs 📉 -88.9%) vs baseline: 📉 -79.4% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.1% ✅ strip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.7% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 2.439µs (SLO: <10.000µs 📉 -75.6%) vs baseline: -1.5% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7% ✅ swapcase_noaspectTime: ✅ 0.540µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.7% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 2.353µs (SLO: <10.000µs 📉 -76.5%) vs baseline: -3.1% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8% ✅ title_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.2% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 3.269µs (SLO: <10.000µs 📉 -67.3%) vs baseline: ~same Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 1.037µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -1.0% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 2.325µs (SLO: <10.000µs 📉 -76.7%) vs baseline: +1.9% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 0.377µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.0% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.9% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.250µs (SLO: <10.000µs 📉 -57.5%) vs baseline: +1.7% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.6% ✅ ospathbasename_noaspectTime: ✅ 1.076µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.2% Memory: ✅ 36.962MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% ✅ ospathjoin_aspectTime: ✅ 6.235µs (SLO: <10.000µs 📉 -37.6%) vs baseline: +3.1% Memory: ✅ 37.041MB (SLO: <39.000MB -5.0%) vs baseline: +3.9% ✅ ospathjoin_noaspectTime: ✅ 2.297µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.3% Memory: ✅ 36.982MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% ✅ ospathnormcase_aspectTime: ✅ 3.534µs (SLO: <10.000µs 📉 -64.7%) vs baseline: +4.8% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.4% ✅ ospathnormcase_noaspectTime: ✅ 0.571µs (SLO: <10.000µs 📉 -94.3%) vs baseline: ~same Memory: ✅ 36.982MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% ✅ ospathsplit_aspectTime: ✅ 4.871µs (SLO: <10.000µs 📉 -51.3%) vs baseline: +2.5% Memory: ✅ 37.021MB (SLO: <39.000MB -5.1%) vs baseline: +3.6% ✅ ospathsplit_noaspectTime: ✅ 1.592µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.7% Memory: ✅ 37.002MB (SLO: <39.000MB -5.1%) vs baseline: +3.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.668µs (SLO: <10.000µs 📉 -63.3%) vs baseline: +2.4% Memory: ✅ 37.002MB (SLO: <39.000MB -5.1%) vs baseline: +3.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.693µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -1.3% Memory: ✅ 36.982MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% ✅ ospathsplitext_aspectTime: ✅ 5.489µs (SLO: <10.000µs 📉 -45.1%) vs baseline: 📈 +23.8% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.4% ✅ ospathsplitext_noaspectTime: ✅ 1.380µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -1.1% Memory: ✅ 36.982MB (SLO: <39.000MB -5.2%) vs baseline: +3.6% 📈 iastpropagation - 8/8✅ no-propagationTime: ✅ 49.211µs (SLO: <60.000µs 📉 -18.0%) vs baseline: +0.9% Memory: ✅ 37.041MB (SLO: <39.000MB -5.0%) vs baseline: +4.9% ✅ propagation_enabledTime: ✅ 168.661µs (SLO: <190.000µs 📉 -11.2%) vs baseline: 📈 +14.7% Memory: ✅ 37.061MB (SLO: <39.000MB -5.0%) vs baseline: +4.9% ✅ propagation_enabled_100Time: ✅ 1.869ms (SLO: <1.900ms 🟡 -1.6%) vs baseline: 📈 +17.4% Memory: ✅ 37.041MB (SLO: <39.000MB -5.0%) vs baseline: +4.9% ✅ propagation_enabled_1000Time: ✅ 32.231ms (SLO: <35.550ms -9.3%) vs baseline: 📈 +11.4% Memory: ✅ 37.061MB (SLO: <39.000MB -5.0%) vs baseline: +5.0% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 26/26✅ appsecTime: ✅ 20.432ms (SLO: <22.300ms -8.4%) vs baseline: -0.6% Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.344ms (SLO: <1.450ms -7.3%) vs baseline: ~same Memory: ✅ 63.514MB (SLO: <66.000MB -3.8%) vs baseline: +4.8% ✅ iastTime: ✅ 20.486ms (SLO: <22.250ms -7.9%) vs baseline: -0.4% Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.144ms (SLO: <16.550ms -8.5%) vs baseline: -0.4% Memory: ✅ 52.907MB (SLO: <53.500MB 🟡 -1.1%) vs baseline: +4.7% ✅ span-code-originTime: ✅ 26.021ms (SLO: <28.200ms -7.7%) vs baseline: -0.4% Memory: ✅ 66.782MB (SLO: <68.500MB -2.5%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.492ms (SLO: <21.750ms -5.8%) vs baseline: -0.4% Memory: ✅ 64.468MB (SLO: <66.000MB -2.3%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.139ms (SLO: <23.500ms -5.8%) vs baseline: +0.2% Memory: ✅ 65.726MB (SLO: <67.000MB 🟡 -1.9%) vs baseline: +4.7% ✅ tracer-dont-create-db-spansTime: ✅ 19.314ms (SLO: <21.500ms 📉 -10.2%) vs baseline: -0.3% Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.441ms (SLO: <21.750ms -6.0%) vs baseline: -0.3% Memory: ✅ 65.765MB (SLO: <66.000MB 🟡 -0.4%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 18.489ms (SLO: <19.650ms -5.9%) vs baseline: +0.3% Memory: ✅ 64.527MB (SLO: <66.000MB -2.2%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.801ms (SLO: <20.100ms -6.5%) vs baseline: +0.2% Memory: ✅ 64.507MB (SLO: <66.000MB -2.3%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.134ms (SLO: <21.500ms -6.4%) vs baseline: -0.5% Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.284ms (SLO: <22.000ms -7.8%) vs baseline: -0.5% Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 17.995ms (SLO: <19.850ms -9.3%) vs baseline: -0.5% Memory: ✅ 64.523MB (SLO: <65.500MB 🟡 -1.5%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 18.019ms (SLO: <19.400ms -7.1%) vs baseline: -0.3% Memory: ✅ 64.507MB (SLO: <65.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.069ms (SLO: <19.450ms -7.1%) vs baseline: +0.3% Memory: ✅ 64.503MB (SLO: <65.500MB 🟡 -1.5%) vs baseline: +4.9% 🟡 flasksimple - 17/17✅ appsec-getTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: +0.2% Memory: ✅ 62.344MB (SLO: <64.500MB -3.3%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.572ms (SLO: <6.750ms -2.6%) vs baseline: ~same Memory: ✅ 62.443MB (SLO: <64.500MB -3.2%) vs baseline: +5.0% ✅ appsec-telemetryTime: ✅ 4.579ms (SLO: <4.750ms -3.6%) vs baseline: +0.2% Memory: ✅ 62.285MB (SLO: <64.500MB -3.4%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.853ms (SLO: <2.000ms -7.4%) vs baseline: +0.2% Memory: ✅ 44.709MB (SLO: <45.000MB 🟡 -0.6%) vs baseline: +5.1% ✅ iast-getTime: ✅ 1.859ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 41.661MB (SLO: <49.000MB 📉 -15.0%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.915ms (SLO: <2.100ms -8.8%) vs baseline: +0.2% Memory: ✅ 44.355MB (SLO: <46.500MB -4.6%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.383ms (SLO: <3.650ms -7.3%) vs baseline: +0.3% Memory: ✅ 51.433MB (SLO: <53.500MB -3.9%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.374ms (SLO: <3.650ms -7.6%) vs baseline: -0.1% Memory: ✅ 52.750MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +5.0% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.945ms (SLO: <4.200ms -6.1%) vs baseline: ~same Memory: ✅ 62.506MB (SLO: <66.000MB -5.3%) vs baseline: +4.7% ✅ iast-enabledTime: ✅ 2.478ms (SLO: <2.800ms 📉 -11.5%) vs baseline: -1.8% Memory: ✅ 58.203MB (SLO: <59.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 2.077ms (SLO: <2.250ms -7.7%) vs baseline: -0.2% Memory: ✅ 51.239MB (SLO: <53.500MB -4.2%) vs baseline: +4.7% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 45.120ms (SLO: <47.150ms -4.3%) vs baseline: -0.2% Memory: ✅ 44.642MB (SLO: <46.500MB -4.0%) vs baseline: +4.8% ✅ add-metricsTime: ✅ 320.282ms (SLO: <344.800ms -7.1%) vs baseline: +0.5% Memory: ✅ 552.591MB (SLO: <562.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ add-tagsTime: ✅ 290.483ms (SLO: <314.000ms -7.5%) vs baseline: -0.9% Memory: ✅ 554.390MB (SLO: <563.500MB 🟡 -1.6%) vs baseline: +4.8% ✅ get-contextTime: ✅ 82.853ms (SLO: <92.350ms 📉 -10.3%) vs baseline: ~same Memory: ✅ 39.709MB (SLO: <46.500MB 📉 -14.6%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 42.996ms (SLO: <44.500ms -3.4%) vs baseline: +0.2% Memory: ✅ 44.006MB (SLO: <46.500MB -5.4%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 61.886ms (SLO: <67.650ms -8.5%) vs baseline: +0.2% Memory: ✅ 39.995MB (SLO: <46.500MB 📉 -14.0%) vs baseline: +4.6% ✅ set-statusTime: ✅ 48.707ms (SLO: <50.400ms -3.4%) vs baseline: -0.4% Memory: ✅ 44.040MB (SLO: <46.500MB -5.3%) vs baseline: +4.9% ✅ startTime: ✅ 42.156ms (SLO: <43.450ms -3.0%) vs baseline: -0.6% Memory: ✅ 44.007MB (SLO: <46.500MB -5.4%) vs baseline: +4.6% ✅ start-finishTime: ✅ 82.329ms (SLO: <88.000ms -6.4%) vs baseline: ~same Memory: ✅ 33.915MB (SLO: <46.500MB 📉 -27.1%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 83.746ms (SLO: <89.000ms -5.9%) vs baseline: -0.5% Memory: ✅ 33.935MB (SLO: <46.500MB 📉 -27.0%) vs baseline: +5.0% ✅ update-nameTime: ✅ 44.015ms (SLO: <45.150ms -2.5%) vs baseline: -0.7% Memory: ✅ 44.391MB (SLO: <46.500MB -4.5%) vs baseline: +4.9%
|
This PR doesn't modify the logic, it's only to simplify and reduce the number of modification of the main PR IAST Context refactor #14513: - move asm_config.is_iast_request_enabled inside the is_iast_request_enabled() - move _num_objects_tainted_in_request to _iast_request_context_base.py ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few random questions, but otherwise lgtm
Overview
It replaces the thread/process fragile map semantics with a bounded, request-scoped context backed by a native, fixed-size array, and adds end-to-end tests validating Overhead Control Engine (OCE) max-concurrency enforcement across FastAPI, Django, and Flask test apps.
Context and motivation
Related work
What’s in this PR
Core IAST context lifecycle
ddtrace/appsec/_iast/_iast_request_context_base.py
_iast_start_request(span)
now gates with OCE (oce.acquire_request(span)
) and creates a native request context only when needed.IAST_CONTEXT
ContextVar to the active context id.IASTEnvironment(span)
viacore.set_item(IAST.REQUEST_CONTEXT_KEY, ...)
._iast_finish_request(...)
) it updates global limits, discards the environment, and releases the native context.is_iast_request_enabled()
exposes whether the taint-tracking context is active in the current execution.Rollout plan
Checklist
Reviewer Checklist