-
Notifications
You must be signed in to change notification settings - Fork 455
fix(llmobs): [MLOB-3863] openai agents support reasoning messages #14522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 266 ± 2 ms. The average import time from base is: 269 ± 3 ms. The import time difference between this PR and base is: -2.9 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: nicole-cybul/minor-integration-fixes (f3fb4f0) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release note lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple non-blocking questions but LGTM!
While QA-ing our agentic integrations, I noticed a bug in the current Open AI Agent's output message parsing. The content field on OpenAI's
ResponseReasoningItem
is optional (ref) which we were not handling properly leading to potentialNoneType
errors like the one below:While investigating this issue, I noticed that our OpenAI integration had a nearly identical implementation for parsing input and output messages, so I decided to extract the common logic into a helper function that could be reused across the OpenAI and OpenAI Agents integrations. This fixed the
NoneType
error since now we do not try to iterate overitem.content
for reasoning message types.Manual Testing
Here is a trace that I created with this feature branch which can be compared with this trace from the main branch.
NoneType
error).Checklist
Reviewer Checklist