Skip to content

fix(aap): status code for downstream requests #14534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

fix(aap): status code for downstream requests #14534

merged 1 commit into from
Sep 10, 2025

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Sep 9, 2025 •
edited
Loading

The implementation of api10 was sending status code for downstream requests as an unsigned integer while libddwaf is expecting a string.
This fixes that.

This will be extensively tested in system tests (problem was discovered on ST)

APPSEC-58715

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@christophe-papazian christophe-papazian added the ASM Application Security Monitoring label Sep 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/api10_status_code-deb7bbc4c0c2a68e.yaml              @DataDog/apm-python
ddtrace/appsec/_common_module_patches.py                                @DataDog/asm-python

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025 •
edited
Loading

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 269 ± 2 ms.

The average import time from base is: 272 ± 2 ms.

The import time difference between this PR and base is: -2.98 ± 0.1 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 0.139 ms (0.05%)
ddtrace 0.139 ms (0.05%)
ddtrace._logger 0.139 ms (0.05%)
ddtrace.internal.telemetry 0.139 ms (0.05%)
ddtrace.settings._agent 0.139 ms (0.05%)
socket 0.072 ms (0.03%)
ddtrace.settings 0.067 ms (0.02%)
ddtrace.vendor.debtcollector 0.067 ms (0.02%)
ddtrace.vendor 0.067 ms (0.02%)
ddtrace.internal.module 0.067 ms (0.02%)
ddtrace.internal.wrapping.context 0.067 ms (0.02%)
ddtrace.internal.utils.inspection 0.067 ms (0.02%)

The following import paths have shrunk:

ddtrace.auto 2.245 ms (0.84%)
ddtrace.bootstrap.sitecustomize 1.420 ms (0.53%)
ddtrace.bootstrap.preload 1.407 ms (0.52%)
ddtrace.internal.remoteconfig.client 0.666 ms (0.25%)
ddtrace.bootstrap 0.013 ms (0.00%)
ddtrace 0.825 ms (0.31%)
ddtrace._logger 0.147 ms (0.05%)
ddtrace.internal.telemetry 0.147 ms (0.05%)
ddtrace.settings._agent 0.147 ms (0.05%)
socket 0.076 ms (0.03%)
array 0.076 ms (0.03%)
ddtrace.settings 0.072 ms (0.03%)
ddtrace.vendor.debtcollector 0.072 ms (0.03%)
ddtrace.vendor 0.072 ms (0.03%)
ddtrace.internal.module 0.072 ms (0.03%)
ddtrace.internal.wrapping.context 0.072 ms (0.03%)
ddtrace.internal._unpatched 0.029 ms (0.01%)
json 0.029 ms (0.01%)
json.decoder 0.029 ms (0.01%)
re 0.029 ms (0.01%)
enum 0.029 ms (0.01%)
types 0.029 ms (0.01%)

@christophe-papazian christophe-papazian marked this pull request as ready for review September 9, 2025 16:02
@christophe-papazian christophe-papazian requested review from a team as code owners September 9, 2025 16:02
@pr-commenter
Copy link

pr-commenter bot commented Sep 9, 2025

Performance SLOs

Candidate: christophe-papazian/improve_status_code_report_for_api10 (74f8279)

🔵 No Baseline Data (23 suites)
🔵 coreapiscenario - 12/12 (2 unstable)

🔵 No baseline data available for this suite

⚠️ context_with_data_listeners

Time: ⚠️ 13.403µs (SLO: <20.000µs 📉 -33.0%)

Memory: ✅ 31.398MB (SLO: <33.500MB -6.3%)

✅ context_with_data_no_listeners

Time: ✅ 3.410µs (SLO: <10.000µs 📉 -65.9%)

Memory: ✅ 31.379MB (SLO: <33.500MB -6.3%)

⚠️ context_with_data_only_all_listeners

Time: ⚠️ 13.443µs (SLO: <20.000µs 📉 -32.8%)

Memory: ✅ 31.438MB (SLO: <33.500MB -6.2%)

✅ get_item_exists

Time: ✅ 0.579µs (SLO: <10.000µs 📉 -94.2%)

Memory: ✅ 31.477MB (SLO: <33.500MB -6.0%)

✅ get_item_missing

Time: ✅ 0.635µs (SLO: <10.000µs 📉 -93.7%)

Memory: ✅ 31.418MB (SLO: <33.500MB -6.2%)

✅ set_item

Time: ✅ 24.206µs (SLO: <30.000µs 📉 -19.3%)

Memory: ✅ 31.457MB (SLO: <33.500MB -6.1%)

🔵 djangosimple - 26/26

🔵 No baseline data available for this suite

✅ appsec

Time: ✅ 20.718ms (SLO: <22.300ms -7.1%)

Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%)

✅ exception-replay-enabled

Time: ✅ 1.368ms (SLO: <1.450ms -5.6%)

Memory: ✅ 63.447MB (SLO: <66.000MB -3.9%)

✅ iast

Time: ✅ 20.589ms (SLO: <22.250ms -7.5%)

Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%)

✅ profiler

Time: ✅ 15.160ms (SLO: <16.550ms -8.4%)

Memory: ✅ 52.829MB (SLO: <53.500MB 🟡 -1.3%)

✅ span-code-origin

Time: ✅ 26.332ms (SLO: <28.200ms -6.6%)

Memory: ✅ 66.622MB (SLO: <68.500MB -2.7%)

✅ tracer

Time: ✅ 20.679ms (SLO: <21.750ms -4.9%)

Memory: ✅ 64.468MB (SLO: <66.000MB -2.3%)

✅ tracer-and-profiler

Time: ✅ 22.304ms (SLO: <23.500ms -5.1%)

Memory: ✅ 65.631MB (SLO: <67.000MB -2.0%)

✅ tracer-dont-create-db-spans

Time: ✅ 19.547ms (SLO: <21.500ms -9.1%)

Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%)

✅ tracer-native

Time: ✅ 20.670ms (SLO: <21.750ms -5.0%)

Memory: ✅ 65.647MB (SLO: <66.000MB 🟡 -0.5%)

✅ tracer-no-caches

Time: ✅ 18.557ms (SLO: <19.650ms -5.6%)

Memory: ✅ 64.507MB (SLO: <66.000MB -2.3%)

✅ tracer-no-databases

Time: ✅ 18.942ms (SLO: <20.100ms -5.8%)

Memory: ✅ 64.075MB (SLO: <66.000MB -2.9%)

✅ tracer-no-middleware

Time: ✅ 20.293ms (SLO: <21.500ms -5.6%)

Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%)

✅ tracer-no-templates

Time: ✅ 20.461ms (SLO: <22.000ms -7.0%)

Memory: ✅ 64.485MB (SLO: <66.000MB -2.3%)

🔵 errortrackingdjangosimple - 6/6

🔵 No baseline data available for this suite

✅ errortracking-enabled-all

Time: ✅ 18.154ms (SLO: <19.850ms -8.5%)

Memory: ✅ 64.425MB (SLO: <65.500MB 🟡 -1.6%)

✅ errortracking-enabled-user

Time: ✅ 18.126ms (SLO: <19.400ms -6.6%)

Memory: ✅ 64.394MB (SLO: <65.500MB 🟡 -1.7%)

✅ tracer-enabled

Time: ✅ 18.351ms (SLO: <19.450ms -5.7%)

Memory: ✅ 64.409MB (SLO: <65.500MB 🟡 -1.7%)

🔵 errortrackingflasksqli - 6/6

🔵 No baseline data available for this suite

✅ errortracking-enabled-all

Time: ✅ 2.105ms (SLO: <2.300ms -8.5%)

Memory: ✅ 51.332MB (SLO: <53.500MB -4.1%)

✅ errortracking-enabled-user

Time: ✅ 2.142ms (SLO: <2.250ms -4.8%)

Memory: ✅ 51.310MB (SLO: <53.500MB -4.1%)

✅ tracer-enabled

Time: ✅ 2.107ms (SLO: <2.300ms -8.4%)

Memory: ✅ 51.207MB (SLO: <53.500MB -4.3%)

🔵 flasksimple - 17/17

🔵 No baseline data available for this suite

✅ appsec-get

Time: ✅ 4.604ms (SLO: <4.750ms -3.1%)

Memory: ✅ 61.971MB (SLO: <64.500MB -3.9%)

✅ appsec-post

Time: ✅ 6.623ms (SLO: <6.750ms 🟡 -1.9%)

Memory: ✅ 62.364MB (SLO: <64.500MB -3.3%)

✅ appsec-telemetry

Time: ✅ 4.604ms (SLO: <4.750ms -3.1%)

Memory: ✅ 61.932MB (SLO: <64.500MB -4.0%)

✅ debugger

Time: ✅ 1.863ms (SLO: <2.000ms -6.8%)

Memory: ✅ 44.630MB (SLO: <45.000MB 🟡 -0.8%)

✅ iast-get

Time: ✅ 1.857ms (SLO: <2.000ms -7.1%)

Memory: ✅ 41.701MB (SLO: <49.000MB 📉 -14.9%)

✅ profiler

Time: ✅ 1.914ms (SLO: <2.100ms -8.8%)

Memory: ✅ 44.335MB (SLO: <46.500MB -4.7%)

✅ tracer

Time: ✅ 3.385ms (SLO: <3.650ms -7.3%)

Memory: ✅ 51.511MB (SLO: <53.500MB -3.7%)

✅ tracer-native

Time: ✅ 3.387ms (SLO: <3.650ms -7.2%)

Memory: ✅ 52.750MB (SLO: <53.500MB 🟡 -1.4%)

🔵 flasksqli - 6/6

🔵 No baseline data available for this suite

✅ appsec-enabled

Time: ✅ 3.984ms (SLO: <4.200ms -5.1%)

Memory: ✅ 62.576MB (SLO: <66.000MB -5.2%)

✅ iast-enabled

Time: ✅ 2.536ms (SLO: <2.800ms -9.4%)

Memory: ✅ 58.236MB (SLO: <59.000MB 🟡 -1.3%)

✅ tracer-enabled

Time: ✅ 2.095ms (SLO: <2.250ms -6.9%)

Memory: ✅ 51.272MB (SLO: <53.500MB -4.2%)

🔵 httppropagationextract - 60/60

🔵 No baseline data available for this suite

✅ all_styles_all_headers

Time: ✅ 81.523µs (SLO: <100.000µs 📉 -18.5%)

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%)

✅ b3_headers

Time: ✅ 14.332µs (SLO: <20.000µs 📉 -28.3%)

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%)

✅ b3_single_headers

Time: ✅ 13.447µs (SLO: <20.000µs 📉 -32.8%)

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%)

✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 65.052µs (SLO: <80.000µs 📉 -18.7%)

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%)

✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 66.794µs (SLO: <80.000µs 📉 -16.5%)

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%)

✅ empty_headers

Time: ✅ 1.591µs (SLO: <10.000µs 📉 -84.1%)

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%)

✅ full_t_id_datadog_headers

Time: ✅ 23.625µs (SLO: <30.000µs 📉 -21.2%)

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%)

✅ invalid_priority_header

Time: ✅ 6.594µs (SLO: <10.000µs 📉 -34.1%)

Memory: ✅ 31.634MB (SLO: <33.500MB -5.6%)

✅ invalid_span_id_header

Time: ✅ 6.561µs (SLO: <10.000µs 📉 -34.4%)

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%)

✅ invalid_tags_header

Time: ✅ 6.580µs (SLO: <10.000µs 📉 -34.2%)

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%)

✅ invalid_trace_id_header

Time: ✅ 6.560µs (SLO: <10.000µs 📉 -34.4%)

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%)

✅ large_header_no_matches

Time: ✅ 27.599µs (SLO: <30.000µs -8.0%)

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%)

✅ large_valid_headers_all

Time: ✅ 28.782µs (SLO: <40.000µs 📉 -28.0%)

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%)

✅ medium_header_no_matches

Time: ✅ 9.990µs (SLO: <20.000µs 📉 -50.0%)

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%)

✅ medium_valid_headers_all

Time: ✅ 11.309µs (SLO: <20.000µs 📉 -43.5%)

Memory: ✅ 31.457MB (SLO: <33.500MB -6.1%)

✅ none_propagation_style

Time: ✅ 1.693µs (SLO: <10.000µs 📉 -83.1%)

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%)

✅ tracecontext_headers

Time: ✅ 35.033µs (SLO: <40.000µs 📉 -12.4%)

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%)

✅ valid_headers_all

Time: ✅ 6.567µs (SLO: <10.000µs 📉 -34.3%)

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%)

✅ valid_headers_basic

Time: ✅ 6.112µs (SLO: <10.000µs 📉 -38.9%)

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%)

✅ wsgi_empty_headers

Time: ✅ 1.589µs (SLO: <10.000µs 📉 -84.1%)

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%)

✅ wsgi_invalid_priority_header

Time: ✅ 6.632µs (SLO: <10.000µs 📉 -33.7%)

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%)

✅ wsgi_invalid_span_id_header

Time: ✅ 1.599µs (SLO: <10.000µs 📉 -84.0%)

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%)

✅ wsgi_invalid_tags_header

Time: ✅ 6.581µs (SLO: <10.000µs 📉 -34.2%)

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%)

✅ wsgi_invalid_trace_id_header

Time: ✅ 6.613µs (SLO: <10.000µs 📉 -33.9%)

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%)

✅ wsgi_large_header_no_matches

Time: ✅ 28.599µs (SLO: <40.000µs 📉 -28.5%)

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%)

✅ wsgi_large_valid_headers_all

Time: ✅ 29.977µs (SLO: <40.000µs 📉 -25.1%)

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%)

✅ wsgi_medium_header_no_matches

Time: ✅ 10.176µs (SLO: <20.000µs 📉 -49.1%)

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%)

✅ wsgi_medium_valid_headers_all

Time: ✅ 11.588µs (SLO: <20.000µs 📉 -42.1%)

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%)

✅ wsgi_valid_headers_all

Time: ✅ 6.580µs (SLO: <10.000µs 📉 -34.2%)

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%)

✅ wsgi_valid_headers_basic

Time: ✅ 6.136µs (SLO: <10.000µs 📉 -38.6%)

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%)

🔵 httppropagationinject - 16/16

🔵 No baseline data available for this suite

✅ ids_only

Time: ✅ 22.014µs (SLO: <30.000µs 📉 -26.6%)

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%)

✅ with_all

Time: ✅ 34.094µs (SLO: <40.000µs 📉 -14.8%)

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%)

✅ with_dd_origin

Time: ✅ 28.838µs (SLO: <30.000µs -3.9%)

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%)

✅ with_priority_and_origin

Time: ✅ 28.010µs (SLO: <40.000µs 📉 -30.0%)

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%)

✅ with_sampling_priority

Time: ✅ 22.338µs (SLO: <30.000µs 📉 -25.5%)

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%)

✅ with_tags

Time: ✅ 30.777µs (SLO: <40.000µs 📉 -23.1%)

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%)

✅ with_tags_invalid

Time: ✅ 33.773µs (SLO: <40.000µs 📉 -15.6%)

Memory: ✅ 31.595MB (SLO: <33.500MB -5.7%)

✅ with_tags_max_size

Time: ✅ 30.647µs (SLO: <40.000µs 📉 -23.4%)

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%)

🔵 iast_aspects - 40/40

🔵 No baseline data available for this suite

✅ re_expand_aspect

Time: ✅ 31.921µs (SLO: <40.000µs 📉 -20.2%)

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%)

✅ re_expand_noaspect

Time: ✅ 28.602µs (SLO: <40.000µs 📉 -28.5%)

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%)

✅ re_findall_aspect

Time: ✅ 3.690µs (SLO: <10.000µs 📉 -63.1%)

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%)

✅ re_findall_noaspect

Time: ✅ 1.413µs (SLO: <10.000µs 📉 -85.9%)

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%)

✅ re_finditer_aspect

Time: ✅ 4.435µs (SLO: <10.000µs 📉 -55.6%)

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%)

✅ re_finditer_noaspect

Time: ✅ 1.415µs (SLO: <10.000µs 📉 -85.8%)

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%)

✅ re_fullmatch_aspect

Time: ✅ 2.663µs (SLO: <10.000µs 📉 -73.4%)

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%)

✅ re_fullmatch_noaspect

Time: ✅ 1.286µs (SLO: <10.000µs 📉 -87.1%)

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%)

✅ re_group_aspect

Time: ✅ 2.948µs (SLO: <10.000µs 📉 -70.5%)

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%)

✅ re_group_noaspect

Time: ✅ 1.619µs (SLO: <10.000µs 📉 -83.8%)

Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%)

✅ re_groups_aspect

Time: ✅ 3.092µs (SLO: <10.000µs 📉 -69.1%)

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%)

✅ re_groups_noaspect

Time: ✅ 1.698µs (SLO: <10.000µs 📉 -83.0%)

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%)

✅ re_match_aspect

Time: ✅ 2.925µs (SLO: <10.000µs 📉 -70.8%)

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%)

✅ re_match_noaspect

Time: ✅ 1.293µs (SLO: <10.000µs 📉 -87.1%)

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%)

✅ re_search_aspect

Time: ✅ 2.547µs (SLO: <10.000µs 📉 -74.5%)

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%)

✅ re_search_noaspect

Time: ✅ 1.197µs (SLO: <10.000µs 📉 -88.0%)

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%)

✅ re_sub_aspect

Time: ✅ 3.395µs (SLO: <10.000µs 📉 -66.0%)

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%)

✅ re_sub_noaspect

Time: ✅ 1.529µs (SLO: <10.000µs 📉 -84.7%)

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%)

✅ re_subn_aspect

Time: ✅ 3.634µs (SLO: <10.000µs 📉 -63.7%)

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%)

✅ re_subn_noaspect

Time: ✅ 1.607µs (SLO: <10.000µs 📉 -83.9%)

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%)

🔵 iastaspectsospath - 24/24

🔵 No baseline data available for this suite

✅ ospathbasename_aspect

Time: ✅ 4.191µs (SLO: <10.000µs 📉 -58.1%)

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%)

✅ ospathbasename_noaspect

Time: ✅ 1.082µs (SLO: <10.000µs 📉 -89.2%)

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%)

✅ ospathjoin_aspect

Time: ✅ 6.117µs (SLO: <10.000µs 📉 -38.8%)

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%)

✅ ospathjoin_noaspect

Time: ✅ 2.307µs (SLO: <10.000µs 📉 -76.9%)

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%)

✅ ospathnormcase_aspect

Time: ✅ 3.506µs (SLO: <10.000µs 📉 -64.9%)

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%)

✅ ospathnormcase_noaspect

Time: ✅ 0.576µs (SLO: <10.000µs 📉 -94.2%)

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%)

✅ ospathsplit_aspect

Time: ✅ 4.900µs (SLO: <10.000µs 📉 -51.0%)

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%)

✅ ospathsplit_noaspect

Time: ✅ 1.605µs (SLO: <10.000µs 📉 -84.0%)

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%)

✅ ospathsplitdrive_aspect

Time: ✅ 3.737µs (SLO: <10.000µs 📉 -62.6%)

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%)

✅ ospathsplitdrive_noaspect

Time: ✅ 0.696µs (SLO: <10.000µs 📉 -93.0%)

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%)

✅ ospathsplitext_aspect

Time: ✅ 4.554µs (SLO: <10.000µs 📉 -54.5%)

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%)

✅ ospathsplitext_noaspect

Time: ✅ 1.379µs (SLO: <10.000µs 📉 -86.2%)

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%)

🔵 iastaspectssplit - 12/12

🔵 No baseline data available for this suite

✅ rsplit_aspect

Time: ✅ 1.417µs (SLO: <10.000µs 📉 -85.8%)

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%)

✅ rsplit_noaspect

Time: ✅ 0.582µs (SLO: <10.000µs 📉 -94.2%)

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%)

✅ split_aspect

Time: ✅ 1.357µs (SLO: <10.000µs 📉 -86.4%)

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%)

✅ split_noaspect

Time: ✅ 0.565µs (SLO: <10.000µs 📉 -94.3%)

Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%)

✅ splitlines_aspect

Time: ✅ 1.367µs (SLO: <10.000µs 📉 -86.3%)

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%)

✅ splitlines_noaspect

Time: ✅ 0.588µs (SLO: <10.000µs 📉 -94.1%)

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%)

🔵 iastpropagation - 8/8

🔵 No baseline data available for this suite

✅ no-propagation

Time: ✅ 48.765µs (SLO: <60.000µs 📉 -18.7%)

Memory: ✅ 37.021MB (SLO: <39.000MB -5.1%)

✅ propagation_enabled

Time: ✅ 146.576µs (SLO: <160.000µs -8.4%)

Memory: ✅ 37.002MB (SLO: <39.000MB -5.1%)

✅ propagation_enabled_100

Time: ✅ 1.587ms (SLO: <1.800ms 📉 -11.8%)

Memory: ✅ 36.982MB (SLO: <39.000MB -5.2%)

✅ propagation_enabled_1000

Time: ✅ 29.225ms (SLO: <30.550ms -4.3%)

Memory: ✅ 37.080MB (SLO: <39.000MB -4.9%)

🔵 otelsdkspan - 24/24

🔵 No baseline data available for this suite

✅ add-event

Time: ✅ 40.380ms (SLO: <42.000ms -3.9%)

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%)

✅ add-link

Time: ✅ 36.497ms (SLO: <38.550ms -5.3%)

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%)

✅ add-metrics

Time: ✅ 220.451ms (SLO: <232.000ms -5.0%)

Memory: ✅ 34.249MB (SLO: <39.000MB 📉 -12.2%)

✅ add-tags

Time: ✅ 211.205ms (SLO: <221.600ms -4.7%)

Memory: ✅ 34.269MB (SLO: <39.000MB 📉 -12.1%)

✅ get-context

Time: ✅ 29.098ms (SLO: <31.300ms -7.0%)

Memory: ✅ 34.347MB (SLO: <39.000MB 📉 -11.9%)

✅ is-recording

Time: ✅ 29.302ms (SLO: <31.000ms -5.5%)

Memory: ✅ 34.347MB (SLO: <39.000MB 📉 -11.9%)

✅ record-exception

Time: ✅ 63.045ms (SLO: <65.850ms -4.3%)

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%)

✅ set-status

Time: ✅ 31.883ms (SLO: <34.150ms -6.6%)

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%)

✅ start

Time: ✅ 28.767ms (SLO: <30.150ms -4.6%)

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%)

✅ start-finish

Time: ✅ 34.058ms (SLO: <35.350ms -3.7%)

Memory: ✅ 34.249MB (SLO: <39.000MB 📉 -12.2%)

✅ start-finish-telemetry

Time: ✅ 34.093ms (SLO: <35.450ms -3.8%)

Memory: ✅ 34.347MB (SLO: <39.000MB 📉 -11.9%)

✅ update-name

Time: ✅ 31.147ms (SLO: <33.400ms -6.7%)

Memory: ✅ 34.269MB (SLO: <39.000MB 📉 -12.1%)

🔵 otelspan - 22/22

🔵 No baseline data available for this suite

✅ add-event

Time: ✅ 45.073ms (SLO: <47.150ms -4.4%)

Memory: ✅ 44.553MB (SLO: <46.500MB -4.2%)

✅ add-metrics

Time: ✅ 322.402ms (SLO: <344.800ms -6.5%)

Memory: ✅ 553.779MB (SLO: <562.000MB 🟡 -1.5%)

✅ add-tags

Time: ✅ 290.778ms (SLO: <314.000ms -7.4%)

Memory: ✅ 554.602MB (SLO: <563.500MB 🟡 -1.6%)

✅ get-context

Time: ✅ 85.316ms (SLO: <92.350ms -7.6%)

Memory: ✅ 39.798MB (SLO: <46.500MB 📉 -14.4%)

✅ is-recording

Time: ✅ 42.977ms (SLO: <44.500ms -3.4%)

Memory: ✅ 44.016MB (SLO: <46.500MB -5.3%)

✅ record-exception

Time: ✅ 61.631ms (SLO: <67.650ms -8.9%)

Memory: ✅ 40.064MB (SLO: <46.500MB 📉 -13.8%)

✅ set-status

Time: ✅ 48.766ms (SLO: <50.400ms -3.2%)

Memory: ✅ 44.024MB (SLO: <46.500MB -5.3%)

✅ start

Time: ✅ 42.279ms (SLO: <43.450ms -2.7%)

Memory: ✅ 43.977MB (SLO: <46.500MB -5.4%)

✅ start-finish

Time: ✅ 82.695ms (SLO: <88.000ms -6.0%)

Memory: ✅ 33.994MB (SLO: <46.500MB 📉 -26.9%)

✅ start-finish-telemetry

Time: ✅ 84.237ms (SLO: <89.000ms -5.4%)

Memory: ✅ 33.954MB (SLO: <46.500MB 📉 -27.0%)

✅ update-name

Time: ✅ 44.141ms (SLO: <45.150ms -2.2%)

Memory: ✅ 44.370MB (SLO: <46.500MB -4.6%)

🔵 packagespackageforrootmodulemapping - 4/4

🔵 No baseline data available for this suite

✅ cache_off

Time: ✅ 341.920ms (SLO: <354.300ms -3.5%)

Memory: ✅ 37.506MB (SLO: <40.000MB -6.2%)

✅ cache_on

Time: ✅ 0.392µs (SLO: <10.000µs 📉 -96.1%)

Memory: ✅ 36.448MB (SLO: <39.000MB -6.5%)

🔵 packagesupdateimporteddependencies - 24/24

🔵 No baseline data available for this suite

✅ import_many

Time: ✅ 154.800µs (SLO: <170.000µs -8.9%)

Memory: ✅ 36.161MB (SLO: <38.500MB -6.1%)

✅ import_many_cached

Time: ✅ 120.696µs (SLO: <130.000µs -7.2%)

Memory: ✅ 36.009MB (SLO: <38.500MB -6.5%)

✅ import_many_stdlib

Time: ✅ 1.609ms (SLO: <1.750ms -8.1%)

Memory: ✅ 36.222MB (SLO: <38.500MB -5.9%)

✅ import_many_stdlib_cached

Time: ✅ 0.966ms (SLO: <1.100ms 📉 -12.2%)

Memory: ✅ 36.378MB (SLO: <38.500MB -5.5%)

✅ import_many_unknown

Time: ✅ 836.357µs (SLO: <890.000µs -6.0%)

Memory: ✅ 36.227MB (SLO: <38.500MB -5.9%)

✅ import_many_unknown_cached

Time: ✅ 804.837µs (SLO: <870.000µs -7.5%)

Memory: ✅ 36.232MB (SLO: <38.500MB -5.9%)

✅ import_one

Time: ✅ 19.807µs (SLO: <30.000µs 📉 -34.0%)

Memory: ✅ 36.024MB (SLO: <39.000MB -7.6%)

✅ import_one_cache

Time: ✅ 6.275µs (SLO: <10.000µs 📉 -37.2%)

Memory: ✅ 36.076MB (SLO: <38.500MB -6.3%)

✅ import_one_stdlib

Time: ✅ 18.853µs (SLO: <20.000µs -5.7%)

Memory: ✅ 36.205MB (SLO: <38.500MB -6.0%)

✅ import_one_stdlib_cache

Time: ✅ 6.258µs (SLO: <10.000µs 📉 -37.4%)

Memory: ✅ 36.304MB (SLO: <38.500MB -5.7%)

✅ import_one_unknown

Time: ✅ 45.459µs (SLO: <50.000µs -9.1%)

Memory: ✅ 36.021MB (SLO: <38.500MB -6.4%)

✅ import_one_unknown_cache

Time: ✅ 6.294µs (SLO: <10.000µs 📉 -37.1%)

Memory: ✅ 36.376MB (SLO: <38.500MB -5.5%)

🔵 ratelimiter - 12/12

🔵 No baseline data available for this suite

✅ defaults

Time: ✅ 2.356µs (SLO: <10.000µs 📉 -76.4%)

Memory: ✅ 31.025MB (SLO: <34.000MB -8.8%)

✅ high_rate_limit

Time: ✅ 2.412µs (SLO: <10.000µs 📉 -75.9%)

Memory: ✅ 31.084MB (SLO: <34.000MB -8.6%)

✅ long_window

Time: ✅ 2.353µs (SLO: <10.000µs 📉 -76.5%)

Memory: ✅ 31.064MB (SLO: <34.000MB -8.6%)

✅ low_rate_limit

Time: ✅ 2.366µs (SLO: <10.000µs 📉 -76.3%)

Memory: ✅ 31.064MB (SLO: <34.000MB -8.6%)

✅ no_rate_limit

Time: ✅ 0.826µs (SLO: <10.000µs 📉 -91.7%)

Memory: ✅ 31.064MB (SLO: <34.000MB -8.6%)

✅ short_window

Time: ✅ 2.500µs (SLO: <10.000µs 📉 -75.0%)

Memory: ✅ 31.044MB (SLO: <34.000MB -8.7%)

🔵 recursivecomputation - 8/8

🔵 No baseline data available for this suite

✅ deep

Time: ✅ 309.206ms (SLO: <320.950ms -3.7%)

Memory: ✅ 32.617MB (SLO: <34.500MB -5.5%)

✅ deep-profiled

Time: ✅ 326.267ms (SLO: <359.150ms -9.2%)

Memory: ✅ 35.134MB (SLO: <39.000MB -9.9%)

✅ medium

Time: ✅ 7.072ms (SLO: <7.400ms -4.4%)

Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%)

✅ shallow

Time: ✅ 0.955ms (SLO: <1.050ms -9.0%)

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%)

🔵 samplingrules - 8/8

🔵 No baseline data available for this suite

✅ average_match

Time: ✅ 274.740µs (SLO: <290.000µs -5.3%)

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%)

✅ high_match

Time: ✅ 445.455µs (SLO: <480.000µs -7.2%)

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%)

✅ low_match

Time: ✅ 110.419µs (SLO: <120.000µs -8.0%)

Memory: ✅ 632.074MB (SLO: <700.000MB -9.7%)

✅ very_low_match

Time: ✅ 7.676ms (SLO: <8.500ms -9.7%)

Memory: ✅ 69.647MB (SLO: <75.000MB -7.1%)

🔵 sethttpmeta - 32/32

🔵 No baseline data available for this suite

✅ all-disabled

Time: ✅ 12.079µs (SLO: <20.000µs 📉 -39.6%)

Memory: ✅ 32.303MB (SLO: <34.000MB -5.0%)

✅ all-enabled

Time: ✅ 42.207µs (SLO: <50.000µs 📉 -15.6%)

Memory: ✅ 32.303MB (SLO: <34.000MB -5.0%)

✅ collectipvariant_exists

Time: ✅ 42.838µs (SLO: <50.000µs 📉 -14.3%)

Memory: ✅ 32.381MB (SLO: <34.000MB -4.8%)

✅ no-collectipvariant

Time: ✅ 42.112µs (SLO: <50.000µs 📉 -15.8%)

Memory: ✅ 32.322MB (SLO: <34.000MB -4.9%)

✅ no-useragentvariant

Time: ✅ 40.925µs (SLO: <50.000µs 📉 -18.1%)

Memory: ✅ 32.322MB (SLO: <34.000MB -4.9%)

✅ obfuscation-no-query

Time: ✅ 42.527µs (SLO: <50.000µs 📉 -14.9%)

Memory: ✅ 32.322MB (SLO: <34.000MB -4.9%)

✅ obfuscation-regular-case-explicit-query

Time: ✅ 79.031µs (SLO: <90.000µs 📉 -12.2%)

Memory: ✅ 32.303MB (SLO: <34.000MB -5.0%)

✅ obfuscation-regular-case-implicit-query

Time: ✅ 79.551µs (SLO: <90.000µs 📉 -11.6%)

Memory: ✅ 32.322MB (SLO: <34.000MB -4.9%)

✅ obfuscation-send-querystring-disabled

Time: ✅ 157.155µs (SLO: <170.000µs -7.6%)

Memory: ✅ 32.322MB (SLO: <34.500MB -6.3%)

✅ obfuscation-worst-case-explicit-query

Time: ✅ 151.566µs (SLO: <160.000µs -5.3%)

Memory: ✅ 32.303MB (SLO: <34.500MB -6.4%)

✅ obfuscation-worst-case-implicit-query

Time: ✅ 157.550µs (SLO: <170.000µs -7.3%)

Memory: ✅ 32.303MB (SLO: <34.500MB -6.4%)

✅ useragentvariant_exists_1

Time: ✅ 41.747µs (SLO: <50.000µs 📉 -16.5%)

Memory: ✅ 32.381MB (SLO: <34.000MB -4.8%)

✅ useragentvariant_exists_2

Time: ✅ 42.828µs (SLO: <50.000µs 📉 -14.3%)

Memory: ✅ 32.362MB (SLO: <34.000MB -4.8%)

✅ useragentvariant_exists_3

Time: ✅ 42.140µs (SLO: <50.000µs 📉 -15.7%)

Memory: ✅ 32.322MB (SLO: <34.000MB -4.9%)

✅ useragentvariant_not_exists_1

Time: ✅ 42.405µs (SLO: <50.000µs 📉 -15.2%)

Memory: ✅ 32.342MB (SLO: <34.000MB -4.9%)

✅ useragentvariant_not_exists_2

Time: ✅ 41.757µs (SLO: <50.000µs 📉 -16.5%)

Memory: ✅ 32.303MB (SLO: <34.000MB -5.0%)

🔵 span - 26/26

🔵 No baseline data available for this suite

✅ add-event

Time: ✅ 24.234ms (SLO: <26.200ms -7.5%)

Memory: ✅ 51.071MB (SLO: <53.000MB -3.6%)

✅ add-metrics

Time: ✅ 92.774ms (SLO: <98.350ms -5.7%)

Memory: ✅ 607.531MB (SLO: <961.000MB 📉 -36.8%)

✅ add-tags

Time: ✅ 150.099ms (SLO: <168.550ms 📉 -10.9%)

Memory: ✅ 606.605MB (SLO: <962.500MB 📉 -37.0%)

✅ get-context

Time: ✅ 22.281ms (SLO: <23.700ms -6.0%)

Memory: ✅ 49.891MB (SLO: <53.000MB -5.9%)

✅ is-recording

Time: ✅ 22.614ms (SLO: <23.900ms -5.4%)

Memory: ✅ 49.846MB (SLO: <53.000MB -6.0%)

✅ record-exception

Time: ✅ 42.311ms (SLO: <44.500ms -4.9%)

Memory: ✅ 42.710MB (SLO: <53.000MB 📉 -19.4%)

✅ set-status

Time: ✅ 24.319ms (SLO: <26.000ms -6.5%)

Memory: ✅ 49.832MB (SLO: <53.000MB -6.0%)

✅ start

Time: ✅ 22.110ms (SLO: <23.500ms -5.9%)

Memory: ✅ 49.843MB (SLO: <53.000MB -6.0%)

✅ start-finish

Time: ✅ 51.473ms (SLO: <55.500ms -7.3%)

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%)

✅ start-finish-telemetry

Time: ✅ 52.869ms (SLO: <58.300ms -9.3%)

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%)

✅ start-finish-traceid128

Time: ✅ 55.592ms (SLO: <60.050ms -7.4%)

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%)

✅ start-traceid128

Time: ✅ 22.737ms (SLO: <24.600ms -7.6%)

Memory: ✅ 49.877MB (SLO: <53.000MB -5.9%)

✅ update-name

Time: ✅ 23.189ms (SLO: <24.100ms -3.8%)

Memory: ✅ 50.522MB (SLO: <53.000MB -4.7%)

🔵 telemetryaddmetric - 30/30

🔵 No baseline data available for this suite

✅ 1-count-metric-1-times

Time: ✅ 3.184µs (SLO: <20.000µs 📉 -84.1%)

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%)

✅ 1-count-metrics-100-times

Time: ✅ 215.714µs (SLO: <250.000µs 📉 -13.7%)

Memory: ✅ 31.398MB (SLO: <34.000MB -7.7%)

✅ 1-distribution-metric-1-times

Time: ✅ 3.051µs (SLO: <20.000µs 📉 -84.7%)

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%)

✅ 1-distribution-metrics-100-times

Time: ✅ 193.791µs (SLO: <220.000µs 📉 -11.9%)

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%)

✅ 1-gauge-metric-1-times

Time: ✅ 2.150µs (SLO: <20.000µs 📉 -89.3%)

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%)

✅ 1-gauge-metrics-100-times

Time: ✅ 124.682µs (SLO: <150.000µs 📉 -16.9%)

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%)

✅ 1-rate-metric-1-times

Time: ✅ 3.194µs (SLO: <20.000µs 📉 -84.0%)

Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%)

✅ 1-rate-metrics-100-times

Time: ✅ 218.028µs (SLO: <250.000µs 📉 -12.8%)

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%)

✅ 100-count-metrics-100-times

Time: ✅ 21.843ms (SLO: <23.500ms -7.0%)

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%)

✅ 100-distribution-metrics-100-times

Time: ✅ 1.992ms (SLO: <2.250ms 📉 -11.5%)

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%)

✅ 100-gauge-metrics-100-times

Time: ✅ 1.270ms (SLO: <1.550ms 📉 -18.1%)

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%)

✅ 100-rate-metrics-100-times

Time: ✅ 2.207ms (SLO: <2.550ms 📉 -13.4%)

Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%)

✅ flush-1-metric

Time: ✅ 4.344µs (SLO: <20.000µs 📉 -78.3%)

Memory: ✅ 31.811MB (SLO: <34.000MB -6.4%)

✅ flush-100-metrics

Time: ✅ 183.098µs (SLO: <250.000µs 📉 -26.8%)

Memory: ✅ 31.811MB (SLO: <34.000MB -6.4%)

✅ flush-1000-metrics

Time: ✅ 2.239ms (SLO: <2.500ms 📉 -10.5%)

Memory: ✅ 32.676MB (SLO: <34.500MB -5.3%)

🔵 tracer - 6/6

🔵 No baseline data available for this suite

✅ large

Time: ✅ 30.902ms (SLO: <32.950ms -6.2%)

Memory: ✅ 33.030MB (SLO: <34.500MB -4.3%)

✅ medium

Time: ✅ 2.998ms (SLO: <3.200ms -6.3%)

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%)

✅ small

Time: ✅ 338.558µs (SLO: <370.000µs -8.5%)

Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%)

@christophe-papazian christophe-papazian enabled auto-merge (squash) September 10, 2025 09:11
@christophe-papazian christophe-papazian merged commit ea8e783 into main Sep 10, 2025
976 of 979 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/improve_status_code_report_for_api10 branch September 10, 2025 09:14
brettlangdon pushed a commit that referenced this pull request Sep 10, 2025
@christophe-papazian @brettlangdon
fix(aap): status code for downstream requests (#14534)
d5adf11 
The implementation of api10 was sending status code for downstream
requests as an unsigned integer while libddwaf is expecting a string.
This fixes that.

This will be extensively tested in system tests (problem was discovered
on ST)

APPSEC-58715

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avara1986 avara1986 avara1986 approved these changes

@juanjux juanjux Awaiting requested review from juanjux juanjux is a code owner automatically assigned from DataDog/apm-python

@quinna-h quinna-h Awaiting requested review from quinna-h quinna-h is a code owner automatically assigned from DataDog/apm-python

Assignees
No one assigned
Labels
ASM Application Security Monitoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophe-papazian @avara1986