Skip to content

Conversation

campaigner-prod[bot]
Copy link
Contributor

@campaigner-prod campaigner-prod bot commented Jul 16, 2025

This PR reverts to the legacy docker ARM tags.
This will only be merged if unexpected issues arise from the migration to the new docker ARM runner.
For support, please reach out in #ci-infra-support.

---------- Additional Campaigner Information ----------
Atlas RunID: 47b33354-271a-4d03-9b4f-e5d624199175


Change log entry

None.

@github-actions github-actions bot added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Jul 16, 2025
Copy link

github-actions bot commented Jul 16, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-07-23 08:25:17 UTC

@pr-commenter
Copy link

pr-commenter bot commented Jul 16, 2025

Benchmarks

Benchmark execution time: 2025-07-23 08:50:01

Comparing candidate commit 58b6398 in PR branch engraver-auto-ci-execution/revert-update-docker-arm-runner-1752637178 with baseline commit 6089a89 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:profiling - intern_all 1000 repeated strings

  • 🟩 throughput [+1374.917op/s; +1447.275op/s] or [+6.043%; +6.362%]

@lloeki
Copy link
Member

lloeki commented Jul 16, 2025

Huh. Which one is it then?

#4807

@alee1246 alee1246 marked this pull request as ready for review July 18, 2025 15:04
@alee1246 alee1246 requested a review from a team as a code owner July 18, 2025 15:04
…2612423' into engraver-auto-ci-execution/revert-update-docker-arm-runner-1752637178
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, hopefully we won't need this second PR

Base automatically changed from engraver-auto-ci-execution/update-docker-arm-runner-1752612423 to master July 23, 2025 08:18
@ivoanjo
Copy link
Member

ivoanjo commented Jul 23, 2025

Note: I've merged #4807 . If in a week or two we've not seen any issue, we can go ahead and close this PR.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (6089a89) to head (58b6398).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4809      +/-   ##
==========================================
+ Coverage   97.54%   97.55%   +0.01%     
==========================================
  Files        1488     1488              
  Lines       88999    88999              
  Branches     4634     4634              
==========================================
+ Hits        86811    86820       +9     
+ Misses       2188     2179       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TonyCTHsu
Copy link
Contributor

Note: I've merged #4807 . If in a week or two we've not seen any issue, we can go ahead and close this PR.

The change is applied to the jobs for preparing the image used by the pipeline (after promotion). This typically is not running for every pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants