-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Bump confluent-kafka
to 2.11.1
#21259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am guessing the error we are seeing now is because we need a newer version of the confluent-kafka package now that we are using the confluent images. We are supporting the same versions of kafka but maybe the interaction is different.
@@ -4,7 +4,7 @@ | |||
# If you bump the `confluent-kafka` version, also bump the `librdkafka` version in the `32_install_kerberos.sh` file | |||
post-install-commands = [ | |||
"python -m pip uninstall -y confluent-kafka", | |||
"python -m pip install --no-binary confluent-kafka confluent-kafka==2.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to bring a newer one now that we are using confluent kafka and dropped bitnami?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I assumed that they might have a python client with versions matching the confluent platform version we are using (as is commonly done), but looking at the client versions this is not the case. 2.11.1 seems to be the latest one so we should be good there. It was a wild guess about why tests could be failing.
No, but the failure is expected since the bumped dependency is not yet built at this point so it's pulled the image from it's upstream repository. Once the dependency resolution gets merged we'll see these failures resolve itself. |
@@ -0,0 +1 @@ | |||
Bump `confluent-kafka` to 2.11.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor but still, please, add newline
What does this PR do?
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged