Fix Velero tests and stop using bitnami images #21274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following files, which will be shipped with the agent, were modified in this PR and You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label. List of modified files that will be shipped with the agent |
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
Kyle-Neale
previously approved these changes
Sep 5, 2025
|
It took ages for the test to finish and eventually it failed. But it can run properly locally. I will keep looking into this on Monday. |
temporal-github-worker-1
bot
dismissed
Kyle-Neale’s stale review
Review from Kyle-Neale is dismissed. Related teams and files:
- agent-integrations
- velero/tests/conftest.py
AAraKKe
changed the title
AAraKKe
changed the title
AAraKKe
changed the title
steveny91
approved these changes
Sep 8, 2025
datadog-agent-integrations-bot bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
* Move bitnami image used for testing to bitnami legacy * Add changelog * Increase timeout when installing velero * Decrease timeout for installation. Did not work. * Add custom kubectl image (cherry picked from commit 04d89ef)
3 tasks
steveny91
added a commit
that referenced
this pull request
Sep 9, 2025
* Move bitnami image used for testing to bitnami legacy * Add changelog * Increase timeout when installing velero * Decrease timeout for installation. Did not work. * Add custom kubectl image (cherry picked from commit 04d89ef) Co-authored-by: Juanpe Araque <[email protected]> Co-authored-by: Steven Yuen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modify the repo used by the velero helm chart from the bitnami one to bitnami legacy. This is not a final solution but VMware Tanzu is still discussing a final alternative to the bitnami image.
EDIT: we started using the legacy repo but that created issues on the test setup. The helm chart was timing out in CI, not when running locally. Since the only reason we are using the
bitnami/kubectlimage is because the helmchart uses some utilities other than kubectl, the final fix is create our own debian image withkubectlin it.See: vmware-tanzu/helm-charts#698
Motivation
Do not rely on bitnami images for testing.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged