Perf4 chord grade #12914
Draft
Perf4 chord grade #12914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
valentijnscholten
force-pushed
the
perf4-chord-grade
branch
from
2193b93 to
0abf18d
Compare
github-actions
bot
added
docker
New Migration
valentijnscholten
force-pushed
the
perf4-chord-grade
branch
from
0abf18d to
6008faf
Compare
github-actions
bot
removed
docker
New Migration
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
valentijnscholten
force-pushed
the
perf4-chord-grade
branch
from
6008faf to
5bed9bb
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 4th performance improvement PR in a series of small improvements.
The current implementation of the import and reimport executes the product grading for each finding that is imported. This results in lots of background celery tasks putting a non-trivial strain on the database.
This PR uses a celery chord to reduce this to only two product grading calls.
By design the chord will only start processing once all tasks have been submitted to it, which is after all findings have been imported. So the post processing starts later. But since the product grading calls are not being called anymore for each finding, the net result will almost always be that the processing will finish sooner. For very big imports it might useful to batch the post processing into chords of a certain size, i.e. 1000. That way after 1000 findings imported the processing can already start. You will then have a product grading call for each 1000 findings. I did not yet implement this yet as I wanted to do an MVP and collect feedback first.