Skip to content

product grade: only update product if grade has changed #13123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

product grade: only update product if grade has changed #13123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53b460f
product grade: only update product if grade has changed
valentijnscholten Sep 5, 2025
a9e2e89
product grade: only update product if grade has changed
valentijnscholten Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions dojo/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1598,8 +1598,13 @@ def calculate_grade(product, *args, **kwargs):
aeval = Interpreter()
aeval(system_settings.product_grade)
grade_product = f"grade_product({critical}, {high}, {medium}, {low})"
product.prod_numeric_grade = aeval(grade_product)
super(Product, product).save()
prod_numeric_grade = aeval(grade_product)
if prod_numeric_grade != product.prod_numeric_grade:
logger.debug("Updating product %s grade from %s to %s", product.id, product.prod_numeric_grade, prod_numeric_grade)
product.prod_numeric_grade = prod_numeric_grade
super(Product, product).save()
else:
logger.debug("Product %s grade %i is up to date", product.id, prod_numeric_grade)


def get_celery_worker_status():
Expand Down
6 changes: 3 additions & 3 deletions unittests/test_importers_performance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,10 @@ def test_import_reimport_reimport_performance_no_async_with_product_grading(self
DojoSytemSettingsMiddleware.load()

self.import_reimport_performance(
expected_num_queries1=732,
expected_num_queries1=717,
expected_num_async_tasks1=15,
expected_num_queries2=686,
expected_num_queries2=662,
expected_num_async_tasks2=28,
expected_num_queries3=357,
expected_num_queries3=337,
expected_num_async_tasks3=25,
)