Skip to content

fix(demo): Limit range of separator characters used in demo #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2023
Merged

fix(demo): Limit range of separator characters used in demo #215

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a98013
fix(demo): Support lines ending with and starting with semicolon on d…
DenverCoder1 May 4, 2023
d069b2a
fix(demo): Limit range of separator characters
DenverCoder1 May 5, 2023
65d40c4
Merge branch 'main' into fix-demo-site-with-ending-with-separator
DenverCoder1 May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/demo/js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ let preview = {
const lineInputs = Array.from(document.querySelectorAll(".param[data-index]"));
/**
* Merge an array of lines with a given separator
* @param {array<string>} lines The lines to merge
* @param {array<HTMLInputElement>} lines The line input fields to merge
* @param {string} separator The separator to insert between lines
* @returns The merged lines parameter string
*/
Expand All @@ -56,8 +56,8 @@ let preview = {
// change separator if it's included in the lines
params.separator = ";";
while (mergeLines(lineInputs, "").indexOf(params.separator) >= 0) {
// change last character to next ascii character as long as it's below 127, otherwise add a semicolon
if (params.separator.charCodeAt(params.separator.length - 1) < 127) {
// change last character to next ascii character (';' through '@'), otherwise add a semicolon
if (params.separator.charCodeAt(params.separator.length - 1) < "@".charCodeAt(0)) {
params.separator =
params.separator.slice(0, -1) +
String.fromCharCode(params.separator.charCodeAt(params.separator.length - 1) + 1);
Expand Down