fix: use different UUIDs for each move task command #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnapse
commented
Aug 14, 2025
Comment on lines
+19
to
+20
| // Allow expect.any(), expect.objectContaining(), expect.arrayContaining() usage in test files | ||
| "@typescript-eslint/no-unsafe-assignment": "off" |
There was a problem hiding this comment.
I did not find a better way to get rid of eslint warning against the use of expect.objectContaining and expect.arrayContaining.
Another thing that eslint is warning against is the use of expect.any(String) in test files. Which is a great thing to do when we need it. That triggers a different eslint rule that I'd also consider overriding for test files, if we do not find a better way to make eslint compatible with it.
scottlovegrove
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the linked issue #310 for all the details, including additional information about what the fix is, which is what's implemented in this PR.
This PR also includes new tests for
moveTasks, beyond testing this very issue. This is because there were no tests formoveTasksbefore this work here. I decided to submit them in a new file because the file for task-related tests is already big enough.