common, examples: add new MS STL <chrono> references, fixing breaking changes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starlocke
force-pushed
the
fix-chrono-latest-ms-stl
branch
from
ee93af2 to
04d676d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whereas microsoft/STL#5105 moved various "chrono" solutions to the lib
<chrono>, creating a breaking change, this update applies an update to correct that when using the latest STL, and ggml-org#11836 in the upstreamllama.cppmakes a corrective action of a similar nature, the change requested here should should be worthwhile to accept, too.