Support DI and Mocking better + Support launching app with file for win and linux #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentation and expose the underlying Socket for low level interaction.
…ly access to props This is to address a PR ElectronNET#648 review comment to ensure that only the external users are not able to modify the instance values.
…DI-MOC-Process # Conflicts: # ElectronNET.API/ServiceCollectionExtensions.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combo of #648 & #633 that have conflicts natively with those conflict's addressed
This adds an
IProcessinterface and applies it to the Process class as well as includes it into the IServiceCollection extension method.See the other 2 PR's for details on those.
FYI @GregorBiswanger