Skip to content

Conversation

lnesteroff
Copy link
Collaborator

Added tag factory option for organization module. Combines the factory and var approaches for tags so will be backwards compatible.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@lnesteroff lnesteroff marked this pull request as ready for review June 20, 2025 02:48
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice. Couple comments before this is good to go:

  • the same factory needs to be implemented in the project module
  • we might want to add context.tag_keys and context.tag_values to factories_config and then lookup the parent id for keys and values there, and fallback to the passed in value if the key is missing

@lnesteroff
Copy link
Collaborator Author

This is very nice. Couple comments before this is good to go:

  • the same factory needs to be implemented in the project module
  • we might want to add context.tag_keys and context.tag_values to factories_config and then lookup the parent id for keys and values there, and fallback to the passed in value if the key is missing

Happy to add this to the project module, but isn't this already achieved through the PF? You can incl the tag defs in the PF yamls

@ludoo
Copy link
Collaborator

ludoo commented Jun 20, 2025

But not all project creation goes through pf :)

@lnesteroff
Copy link
Collaborator Author

Great point, would you want it in this PR or separate?

@ludoo
Copy link
Collaborator

ludoo commented Jun 20, 2025

In this PR, with the context replacements too (check our chat) :)

@ludoo ludoo added the enhancement New feature or request label Jun 20, 2025
@ludoo ludoo changed the base branch from master to fast-dev June 21, 2025 15:38
@lnesteroff lnesteroff requested a review from ludoo June 23, 2025 03:50
@lnesteroff lnesteroff merged commit 1fbb2cb into fast-dev Jun 23, 2025
20 checks passed
@lnesteroff lnesteroff deleted the lnesteroff/tag_factory branch June 23, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants