-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Added tag factory option for organization module #3178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice. Couple comments before this is good to go:
- the same factory needs to be implemented in the project module
- we might want to add
context.tag_keys
andcontext.tag_values
tofactories_config
and then lookup the parent id for keys and values there, and fallback to the passed in value if the key is missing
Happy to add this to the project module, but isn't this already achieved through the PF? You can incl the tag defs in the PF yamls |
But not all project creation goes through pf :) |
Great point, would you want it in this PR or separate? |
In this PR, with the context replacements too (check our chat) :) |
…king for ID in yamls
Added tag factory option for organization module. Combines the factory and var approaches for tags so will be backwards compatible.
Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py