chore(modelarmor): enabled floor settings tests

[mihirvala-crestdata]

Description

Enabling floor settings as issue b/424365799 is fixed

Checklist

• I have followed Contributing Guidelines from CONTRIBUTING.MD
• Tests pass: go test -v ./.. (see Testing)
• Code formatted: gofmt (see Formatting)
• Vetting pass: go vet (see Formatting)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[gemini-code-assist]

Summary of Changes

Hello @mihirvala-crestdata, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request re-enables a set of integration tests within the modelarmor module that were previously skipped. These tests, which cover various "floor settings" operations (get and update at project, organization, and folder levels), can now run as the underlying issue that caused them to be skipped has been fixed.

Highlights

• Test Re-enablement: I've re-enabled six previously skipped tests related to modelarmor floor settings. These include TestGetProjectFloorSettings, TestGetOrganizationFloorSettings, TestGetFolderFloorSettings, TestUpdateFolderFloorSettings, TestUpdateOrganizationFloorSettings, and TestUpdateProjectFloorSettings. This was done because the blocking issue b/424365799 has been resolved.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enables several system tests for floor settings, which is great. The changes correctly remove the t.Skip calls. My review focuses on ensuring the newly enabled tests are robust. I've identified a potential issue in the three Update... tests where cleanup logic may not execute on failure, potentially leading to state leakage and affecting other tests. I've provided details in the comments.

[harshnasitcrest]

Tests are failing due to missing permissions. Ref: Logs

Can someone help in granting following IAM permissions to the project/org/folder used in running these tests?

1. modelarmor.floorSettings.update
2. modelarmor.floorSettings.get

CC: @ericschmidtatwork @utsav1810

[harshnasitcrest]

Tests are failing due to missing permissions. Ref: Logs

Can someone help in granting following IAM permissions to the project/org/folder used in running these tests?

1. modelarmor.floorSettings.update
2. modelarmor.floorSettings.get

CC: @ericschmidtatwork @utsav1810

@ericschmidtatwork / @telpirion Can someone look into these?

CC: @bhardwaj-prerna

[harshnasitcrest]

Tests are failing due to missing permissions. Ref: Logs
Can someone help in granting following IAM permissions to the project/org/folder used in running these tests?

1. modelarmor.floorSettings.update
2. modelarmor.floorSettings.get

CC: @ericschmidtatwork @utsav1810

@ericschmidtatwork / @telpirion Can someone look into these?

CC: @bhardwaj-prerna

@glasnt Is there anyone on your team who could help us get unblocked in this repository? It’s been almost a month, and we’ve been unable to get any help here.

[iennae]

@harshnasitcrest, we hear you, and we sincerely apologize for the lack of communication over the last month on this issue. We understand how frustrating it is to feel blocked.

We appreciate your patience. Our small team has been focused on investigating the issues you've encountered, and we're glad to have already helped resolve the problems in your Python, Node.js, and Java code.

We don't have an update yet on what's causing the issues in the Go and PHP samples. We want to be transparent that these are complex and will likely require collaboration to resolve.

We're committed to helping you as best we can. To get a better handle on the remaining issues, would you be open to setting up a GVC with @glasnt ? We'd like to work together to unblock your sample updates.

[harshnasitcrest]

@harshnasitcrest, we hear you, and we sincerely apologize for the lack of communication over the last month on this issue. We understand how frustrating it is to feel blocked.

We appreciate your patience. Our small team has been focused on investigating the issues you've encountered, and we're glad to have already helped resolve the problems in your Python, Node.js, and Java code.

We don't have an update yet on what's causing the issues in the Go and PHP samples. We want to be transparent that these are complex and will likely require collaboration to resolve.

We're committed to helping you as best we can. To get a better handle on the remaining issues, would you be open to setting up a GVC with @glasnt ? We'd like to work together to unblock your sample updates.

@iennae - Thank you for ack 🙇 ! We truly appreciate all the support and assistance we've received from Katie, Eric and your team so far 🙌 . We’re happy to collaborate via GVC to work through the remaining issues 🤝.

@glasnt - Sharing my available slots: https://calendar.app.google/Er4f4LHWVE2aDdpb8
Please let me know if the slots doesn't work for you.

[harshnasitcrest]

@glasnt Could you help add kokoro labels and re-run the tests?

Fixed the tests.

Ref: (Screenshot for successful test run on local machine)

[harshnasitcrest]

@glasnt I ran the lint and go mod tidy commands but no violations are reported on local machine. I see similar failures in other PRs as well. Ref: https://github.com/GoogleCloudPlatform/golang-samples/actions/runs/17224633796/job/48866834290

Is this a known CI issue?

[glasnt]

I've resolved the linting issues; they were unrelated to this change.

However, the tests are now returning "TEMPLATE_NOT_CONFORMANT" errors.

Compare CI results from 24 hours ago: https://btx.cloud.google.com/invocations/403e0558-e8b3-4bce-9c2e-ed98fa3f48ef/log
With recent execution: https://btx.cloud.google.com/invocations/b69ee4b7-4850-4982-a8a8-1c0817f42519/log

Unsure if something at your testing project level has changed in the last day, please investigate.

[harshnasitcrest]

I've resolved the linting issues; they were unrelated to this change.

However, the tests are now returning "TEMPLATE_NOT_CONFORMANT" errors.

Compare CI results from 24 hours ago: https://btx.cloud.google.com/invocations/403e0558-e8b3-4bce-9c2e-ed98fa3f48ef/log With recent execution: https://btx.cloud.google.com/invocations/b69ee4b7-4850-4982-a8a8-1c0817f42519/log

Unsure if something at your testing project level has changed in the last day, please investigate.

It appears that another repository’s test run updated the floor settings before this one started, causing the failures.

I had a discussion with Prerna from the Model Armor team. We agreed to remove the update floor setting tests from all the code sample repositories.

The reason for this is that since all the repositories are using the same folder/org, it’s likely that we’ll face similar failures (or worst case, disabling floor settings after test run fails) in the future, which could impact merging other PRs. Otherwise, to resolve this, we’ll require a separate project/folder/org for each repo. Another solution is to update the code samples accordingly; however, we don’t want to compromise on updating the code samples just for the sake of passing the tests, and anyway, the service level test coverage is sufficient.

[glasnt]

I had a discussion with Prerna from the Model Armor team. We agreed to remove the update floor setting tests from all the code sample repositories.

Per previous advice: please do not delete tests, only mark them skipped, citing an internal bug for later reference.

While having code samples with skipped tests is not best practice, it's better than having samples without any insight to how they can be validated. This will also allow future updates in cases of changes to CI practices, etc.