Skip to content

Conversation

renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Change Age Confidence
golang.org/x/net v0.34.0 -> v0.38.0 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

CVE-2025-22870

Matching of hosts against proxy patterns can improperly treat an IPv6 zone ID as a hostname component. For example, when the NO_PROXY environment variable is set to "*.example.com", a request to "[::1%25.example.com]:80` will incorrectly match and not be proxied.

CVE-2025-22872

The tokenizer incorrectly interprets tags with unquoted attribute values that end with a solidus character (/) as self-closing. When directly using Tokenizer, this can result in such tags incorrectly being marked as self-closing, and when using the Parse functions, this can result in content following such tags as being placed in the wrong scope during DOM construction, but only when tags are in foreign content (e.g. , , etc contexts).


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: endpoints/go.sum
Command failed: install-tool golang 1.21.13

@renovate-bot renovate-bot requested review from a team as code owners August 13, 2025 13:57
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 13, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a critical dependency update for the golang.org/x/net module. The primary purpose of this update is to integrate the latest security patches, thereby enhancing the overall security posture of the application. By upgrading this core networking library, the system gains protection against recently identified vulnerabilities, ensuring more robust and secure operations.

Highlights

  • Dependency Update: The golang.org/x/net module has been updated from version v0.34.0 to v0.38.0.
  • Security Fix (CVE-2025-22870): This update includes fixes for CVE-2025-22870, which addresses an improper handling of IPv6 zone IDs in proxy pattern matching.
  • Security Fix (CVE-2025-22872): This update also resolves CVE-2025-22872, fixing an issue where the HTML tokenizer incorrectly interprets certain tags as self-closing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the golang.org/x/net dependency from v0.34.0 to v0.38.0 to address security vulnerabilities. This is a necessary update. However, the go.sum file has not been updated to reflect this change, which will likely cause build failures. I have added a comment on the go.mod file change to highlight this issue.

@@ -5,7 +5,7 @@ go 1.23.0
require (
github.com/golang/protobuf v1.5.4
github.com/gorilla/mux v1.8.1
golang.org/x/net v0.34.0
golang.org/x/net v0.38.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While the go.mod file is correctly updated, the corresponding go.sum file has not been updated. This will cause build failures due to checksum mismatches. Please run go mod tidy and commit the changes to go.sum to ensure the build remains reproducible and successful.

@renovate-bot renovate-bot force-pushed the renovate/go-golang.org-x-net-vulnerability branch 24 times, most recently from 06acfd8 to 8971772 Compare August 18, 2025 03:04
@renovate-bot renovate-bot force-pushed the renovate/go-golang.org-x-net-vulnerability branch 28 times, most recently from 5505ba7 to 34a3312 Compare September 10, 2025 04:37
@renovate-bot renovate-bot force-pushed the renovate/go-golang.org-x-net-vulnerability branch from 34a3312 to aedcfcd Compare September 10, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant