-
-
Notifications
You must be signed in to change notification settings - Fork 895
Desktop: Move autosave persistence to native #3134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
70e24de
to
7ff64cf
Compare
7ff64cf
to
680a9e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a review of the code and pushed a few nits, and fixed a rebase conflict. But I'll leave this to @TrueDoctor to give a proper approval on.
document_is_auto_saved: true, | ||
document_is_saved: document.is_saved, | ||
to_front, | ||
select_after_open: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the rebase conflict I fixed, since I introduced this select_after_open
field in a PR I added yesterday. You may want to check if false
is appropriate here, or if you want to feed this in as a variable (like to_front
on the line above gets fed in as a variable) so callers of this message can decide on a case-by-case basis.
01b5922
to
4042eb4
Compare
Performance Benchmark Results
|
Performance Benchmark Results
|
Performance Benchmark Results
|
First part of #3114
Saving Preferences natively will be a separate PR