Skip to content

Fix _find_file parent stop condition #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix _find_file parent stop condition #174

wants to merge 1 commit into from

Conversation

jdranczewski
Copy link

Fixes #172 - infinite recursion if parent is on a drive different than the working directory drive under Windows.

lucasrcezimbra
lucasrcezimbra requested changes Aug 25, 2025
View reviewed changes
Copy link
Member

@lucasrcezimbra lucasrcezimbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a test case to avoid regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasrcezimbra lucasrcezimbra lucasrcezimbra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinte recursion on Windows+IPython if caller path on drive different than working path
2 participants
@jdranczewski @lucasrcezimbra